Re: [PATCH] New ubitunefs command to adjust tunable filesystem parameters on ubifs

[Artem Bityutskiy <dedekind1@gmail.com>]

On Fri, 2010-12-31 at 11:08 +0100, stefani@seibold.net wrote:
> From: Stefani Seibold <stefani@seibold.net>
> 
> ubitunefs allows the system administrator to adjust various tunable
> filesystem  parameters on Linux ubifs filesystems. The current values of these
> parameters can be displayed by using the -v or calling without any option.
> 
> Currently the ubitunefs supports the following parameters:
> 
> -x, --compr=<none|lzo|zlib>    compression type
> -R, --reserved=SIZE            how much space should be reserved for super-user
> 
> Maybe it will be nice to adjust also the uid and gid of the reserved owner,
> or the increase the max. size of the ubi filesystem. This will be very simple
> to implement.
> 
> Signed-off-by: Stefani Seibold <stefani@seibold.net>

Stefani,

thanks for the patch. I have not gone through it, but could we please
keep UBI and UBIFS things separate. The "ubi-utils" directory is for
UBI, could we please avoid putting this UBIFS tool there? Instead, would
it please be possible to:
  A. re-name the "mkfs.ubifs" directory into "ubifs-utils", and put your
     new tool there.
  B. re-name the tool to something which suggests a bit better that this
     is about UBIFS (not UBI), e.g.
        * tuneubifs (similar to tune2fs)
        * ubifsctl (similar to btrfsctl)

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)