linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-mtd@lists.infradead.org
Subject: Re: ubifs: sync() causes writes even if nothing is changed
Date: Mon, 17 Jan 2011 23:52:16 +0200	[thread overview]
Message-ID: <1295301136.2470.26.camel@koala> (raw)
In-Reply-To: <4D33FB78.5010208@nokia.com>

[Removed Hans J. Koch from CC as his mailbox is unreachable]

On Mon, 2011-01-17 at 10:19 +0200, Adrian Hunter wrote:
> Possibly the LPT should be checked also.  Perhaps it can be dirty due
> to trivial garbage collection.

Yes, AFAIU we can GC from budgeting, end up with trivial gc which will
make dirt in LTP but not in TNC. So you are right.

But there is another "trival GC" inside lprops subsystem, but I think we
should not worry about it.

> Also, have you checked there are no degenerate cases where the commit
> is required for some other reason such as consolidating the log or the
> recovery  commit?

I do not really see how could recovery be needed if nothing is made
dirty in TNC, but due to complexity of that stuff it is safer to do the
commit if we are mounting or remounting rw, because there may be such
situations.

I'll send new patches shortly, thank you!

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

  parent reply	other threads:[~2011-01-17 21:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 16:30 ubifs: sync() causes writes even if nothing is changed Hans J. Koch
2010-10-15  6:13 ` Artem Bityutskiy
2010-10-20 13:26 ` Artem Bityutskiy
2010-10-21  8:23   ` Sebastian Andrzej Siewior
2010-10-21  8:32     ` Artem Bityutskiy
2010-10-21 17:04       ` Matthieu CASTET
2010-10-21 18:43         ` Artem Bityutskiy
2011-01-16 17:48 ` Artem Bityutskiy
2011-01-17  8:19   ` Adrian Hunter
2011-01-17  9:04     ` Artem Bityutskiy
2011-01-17 21:52     ` Artem Bityutskiy [this message]
2011-01-17 21:53     ` [PATCH v2 1/3] UBIFS: re-arrange variables in ubifs_info Artem Bityutskiy
2011-01-17 21:54       ` [PATCH v2 2/3] UBIFS: introduce mounting flag Artem Bityutskiy
2011-01-18  7:30     ` [PATCH v2 3/3] UBIFS: do not start the commit if there is nothing to commit Artem Bityutskiy
2011-01-18  7:36       ` Artem Bityutskiy
2011-01-18 12:29         ` John Ogness
2011-01-21 11:13           ` Artem Bityutskiy
2011-01-21 11:28             ` John Ogness
2011-01-25  8:20               ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295301136.2470.26.camel@koala \
    --to=dedekind1@gmail.com \
    --cc=adrian.hunter@nokia.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).