From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Pex05-0007HD-Cq for linux-mtd@lists.infradead.org; Mon, 17 Jan 2011 21:52:34 +0000 Received: by fxm19 with SMTP id 19so6529583fxm.36 for ; Mon, 17 Jan 2011 13:52:31 -0800 (PST) Subject: Re: ubifs: sync() causes writes even if nothing is changed From: Artem Bityutskiy To: Adrian Hunter In-Reply-To: <4D33FB78.5010208@nokia.com> References: <20101013163005.GB1889@silverbox.local> <1295200104.2470.5.camel@koala> <4D33FB78.5010208@nokia.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 17 Jan 2011 23:52:16 +0200 Message-ID: <1295301136.2470.26.camel@koala> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Sebastian Andrzej Siewior , linux-mtd@lists.infradead.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , [Removed Hans J. Koch from CC as his mailbox is unreachable] On Mon, 2011-01-17 at 10:19 +0200, Adrian Hunter wrote: > Possibly the LPT should be checked also. Perhaps it can be dirty due > to trivial garbage collection. Yes, AFAIU we can GC from budgeting, end up with trivial gc which will make dirt in LTP but not in TNC. So you are right. But there is another "trival GC" inside lprops subsystem, but I think we should not worry about it. > Also, have you checked there are no degenerate cases where the commit > is required for some other reason such as consolidating the log or the > recovery commit? I do not really see how could recovery be needed if nothing is made dirty in TNC, but due to complexity of that stuff it is safer to do the commit if we are mounting or remounting rw, because there may be such situations. I'll send new patches shortly, thank you! -- Best Regards, Artem Bityutskiy (Битюцкий Артём)