From: Artem Bityutskiy <dedekind1@gmail.com>
To: twebb <taliaferro62@gmail.com>
Cc: Lei Wen <leiwen@marvell.com>, linux-mtd@lists.infradead.org
Subject: Re: ubifs_scan() error handling
Date: Sat, 29 Jan 2011 19:38:18 +0200 [thread overview]
Message-ID: <1296322698.2400.10.camel@localhost> (raw)
In-Reply-To: <AANLkTi==-biDcaFozVvkHUwXMYqMWk4=mbD16_TJ1JOO@mail.gmail.com>
On Fri, 2011-01-28 at 12:13 -0500, twebb wrote:
> It's been awhile but I wanted to reopen the discussion on this topic.
> Could you take a look at this proposed patch? Essentially this change
> results in the LEB being cleaned/recovered regardless of whether
> is_last_write() is true or not. There may be a better way to do this
> earlier in the same function, but I'm not familiar enough with it to
> know the significance of the is_last_write() call.
But I think I explained why this check is there. Why exactly it does not
work for your flash? I think you need to get better understanding what
is happening in your case. I am reluctant to take this patch because it
is more of a band-aid but not a proper solution.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-01-29 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 17:04 ubifs_scan() error handling twebb
2010-07-13 4:28 ` Artem Bityutskiy
2010-07-13 4:32 ` Artem Bityutskiy
2011-01-28 17:13 ` twebb
2011-01-29 17:38 ` Artem Bityutskiy [this message]
2011-02-01 1:26 ` twebb
2011-02-06 14:58 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296322698.2400.10.camel@localhost \
--to=dedekind1@gmail.com \
--cc=leiwen@marvell.com \
--cc=linux-mtd@lists.infradead.org \
--cc=taliaferro62@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).