Re: [PATCH 3/3] mtd: Add mtdswap block driver

[Artem Bityutskiy <dedekind1@gmail.com>]

On Tue, 2011-02-22 at 18:21 +0200, Jarkko Lavinen wrote:
> On Fri, Feb 18, 2011 at 04:14:30PM +0200, ext Artem Bityutskiy wrote:
> > ... what's the problem with re-trying the erase operation - it
> > looks like over-design.
> 
> > Is it please possible to remove this config option?
> 
> I have a Hynix SLC OneNand spec which says an erase block with an
> erase failure or a write error should not be re-written or erased
> again but instead just garbage collected and marked bad.
> 
> If I switch permanently to the strict erase failure handling, bad
> block marking could be too sensitive for some devices expecting
> retries.
> 
> If I switch permanently to the lenient mode, mtdswap would retry
> failed erases which would be against chip spec of at least the one
> OneNand chip I am working with.
> 
> If I remove the config option it would then mean strict handling
> only.

Please, make the option to be a module parameter.

And add this description to the parameter description. Probably this
amount of text is too much for MODULE_PARM_DESC() - put less there, and
put the details to a comment near that MODULE_PARM_DESC().

IOW, I'm not against this option, I'm against making it Kconfig option.

Thanks a lot!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)