linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: viresh kumar <viresh.kumar@st.com>
Cc: Vipin KUMAR <vipin.kumar@st.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h
Date: Fri, 25 Feb 2011 13:12:20 +0200	[thread overview]
Message-ID: <1298632340.2798.68.camel@localhost> (raw)
In-Reply-To: <4D678E56.8050908@st.com>

On Fri, 2011-02-25 at 16:41 +0530, viresh kumar wrote:
> On 02/25/2011 04:37 PM, Artem Bityutskiy wrote:
> > On Fri, 2011-02-25 at 09:14 +0530, viresh kumar wrote:
> >> > On 02/24/2011 06:08 PM, Linus Walleij wrote:
> >>> > > 2011/2/23 Viresh Kumar <viresh.kumar@st.com>:
> >>> > > 
> >>>>> > >> > In most of the cases partitions info, width, etc comes from board files. And
> >>>>> > >> > device structure may be defined in machine files, common to all board files.
> >>>>> > >> > Thus, we need to set platform data from board file, for which
> >>>>> > >> > fsmc_nand_set_plat_data routine is required.
> >>> > > Hm you create a new function, but where is it used? If it's used by a later
> >>> > > patch perhaps you should make a patch series instead?
> >> > 
> >> > Linus,
> >> > 
> >> > Actually it will be used in SPEAr patches, which will be sent separately. I could
> >> > have kept it as part of that series also, but just thought to send it separately.
> >> > You want me to keep it in spear patch series instead?
> > I think this is important piece of information which should be in the
> > patch commit message.
> 
> Ok. I will resend it.

To elaborate, imagine I put this patch to my l2 tree, then David has the
same question when he decides whether to pick it or not.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

  reply	other threads:[~2011-02-25 11:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23  6:49 [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h Viresh Kumar
2011-02-24 12:38 ` Linus Walleij
2011-02-25  3:44   ` viresh kumar
2011-02-25  8:39     ` Linus Walleij
2011-02-25 11:07     ` Artem Bityutskiy
2011-02-25 11:11       ` viresh kumar
2011-02-25 11:12         ` Artem Bityutskiy [this message]
2011-02-25 11:11 ` Artem Bityutskiy
2011-02-25 11:22   ` viresh kumar
2011-02-25 11:25     ` Artem Bityutskiy
2011-02-25 11:43       ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298632340.2798.68.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vipin.kumar@st.com \
    --cc=viresh.kumar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).