From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ww0-f49.google.com ([74.125.82.49]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1Psvp8-0003C7-Q5 for linux-mtd@lists.infradead.org; Fri, 25 Feb 2011 11:27:03 +0000 Received: by wwb29 with SMTP id 29so1358896wwb.18 for ; Fri, 25 Feb 2011 03:27:01 -0800 (PST) Subject: Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h From: Artem Bityutskiy To: viresh kumar In-Reply-To: <4D6790FD.9060807@st.com> References: <1298632262.2798.66.camel@localhost> <4D6790FD.9060807@st.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 25 Feb 2011 13:25:38 +0200 Message-ID: <1298633138.2798.72.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Vipin KUMAR , "linux-mtd@lists.infradead.org" , "dwmw2@infradead.org" , Linus WALLEIJ Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2011-02-25 at 16:52 +0530, viresh kumar wrote: > Actually this routine will not be called many times. Which means it is not on the hot path which means inline is not really needed. Also, today it is not called too many times, tomorrow it could be called more often... > Only for setting > plat_data of few devices (depending on board). So i thought keeping > it inline would be better. But will change if you want. Should i move > it in fsmc-nand.c?? Hi, up to you, I would not keep it in a header file, this is more about personal taste, I guess. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)