Re: [PATCH v2 0/5] UBIFS: fix recovery on CFI NOR

Artem Bityutskiy
2011-03-07T13:51:40Z

On Mon, 2011-03-07 at 14:05 +0100, Anatolij Gustschin wrote:
> On Mon, 07 Mar 2011 13:39:50 +0200
> Artem Bityutskiy <dedekind1@gmail.com> wrote:
>
> > On Sun, 2011-02-06 at 15:17 +0200, Artem Bityutskiy wrote:
> > > Hi,
> > >
> > > here is a better patch for recovery fix. Comparing to the previous
> > > patch-set now we make sure we keep write-buffer offset aligned to
> > > @c->max_write_size (64 in case of CFI NOR) as much as possible.
> > >
> > > Also, I've merged the "Add comments" patch with the patch which adds
> > > the code.
> > >
> > > You can find these patches also in the UBIFS git tree, 'cfi-nor-fix-v2'
> > > branch:
> > > git://git.infradead.org/ubifs-2.6.git cfi-nor-fix-v2
> > >
> > > Please, test. These patches may break NAND setups as well, so anyone
> > > who is interested in having stable UBIFS in the next release, please,
> > > also test.
> >
> > Anatolij,
> >
> > did these patches fix your issues. I know you found another one related
> > to unstable bits, but it is a separate issue. I need to make a decision
> > whether my patches go upstream the next merge window or they should
> > wait.
> >
> > I have v3 of the patches, but they are not very different from v2. I
> > will send them out as well.
>
> Hi Artem,
>
> Yes, together with both patches from
> "[PATCH 0/2] Further fixes for UBIFS recovery on CFI NOR" series
> these patches fix UBIFS recovery issues on our NOR flash. Remaining
> issue seems to be CRC-Error due to unstable bits in UBIFS data node.

OK, thanks, then I think they should be merged.

WRT unstable bits - are you planning to invest any time into that issue?

--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)