* [PATCH v2] NAND: DaVinci: Removed header file that is not required
@ 2011-03-07 18:50 s-paulraj
2011-03-08 12:33 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: s-paulraj @ 2011-03-07 18:50 UTC (permalink / raw)
To: davinci-linux-open-source, linux-mtd, dedekind1; +Cc: Sandeep Paulraj
From: Sandeep Paulraj <s-paulraj@ti.com>
The DaVinci NAND driver was including the mach-types.h header
file.
This prevented the DaVinci NAND driver from getting used
in a DSP only device. The linux port on c6x devices can make
use of the same driver and does not define a corresponding
header file.
This header file was required in the driver because earlier there was code
dependent on a machine_* check. This piece of code has now been factored out
and is in arch/arm/mach-davinci/aemif.c
Thus removing the header file is harmless
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
---
Changes since V1
-better patch description based on Artem's comments
drivers/mtd/nand/davinci_nand.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index a90fde3..aff3468 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -37,9 +37,6 @@
#include <mach/nand.h>
#include <mach/aemif.h>
-#include <asm/mach-types.h>
-
-
/*
* This is a device driver for the NAND flash controller found on the
* various DaVinci family chips. It handles up to four SoC chipselects,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] NAND: DaVinci: Removed header file that is not required
2011-03-07 18:50 [PATCH v2] NAND: DaVinci: Removed header file that is not required s-paulraj
@ 2011-03-08 12:33 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2011-03-08 12:33 UTC (permalink / raw)
To: s-paulraj; +Cc: davinci-linux-open-source, linux-mtd
On Mon, 2011-03-07 at 13:50 -0500, s-paulraj@ti.com wrote:
> From: Sandeep Paulraj <s-paulraj@ti.com>
>
> The DaVinci NAND driver was including the mach-types.h header
> file.
> This prevented the DaVinci NAND driver from getting used
> in a DSP only device. The linux port on c6x devices can make
> use of the same driver and does not define a corresponding
> header file.
>
> This header file was required in the driver because earlier there was code
> dependent on a machine_* check. This piece of code has now been factored out
> and is in arch/arm/mach-davinci/aemif.c
>
> Thus removing the header file is harmless
>
> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
Pushed to l2-mtd-2.6.git, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-08 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-07 18:50 [PATCH v2] NAND: DaVinci: Removed header file that is not required s-paulraj
2011-03-08 12:33 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox