From: Artem Bityutskiy <dedekind1@gmail.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-mtd@lists.infradead.org, Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [RFC PATCH] mtd: mxc_nand: fix OOB corruption when page size > 2k
Date: Thu, 10 Mar 2011 15:02:59 +0200 [thread overview]
Message-ID: <1299762179.6676.4.camel@localhost> (raw)
In-Reply-To: <c3d5dae673b532b4a4dbdb8edc6626aa49d7a626.1299679613.git.baruch@tkos.co.il>
On Wed, 2011-03-09 at 16:12 +0200, Baruch Siach wrote:
> When page size is 4k, ecc.total is set to 8*9, and this causes
> nand_write_page_hwecc() to read past the initialized part of the eccpos array,
> which corrupts chip->oob_poi with bogus values from ecc_calc.
>
> Fix this by creating a proper nand_ecclayout for 4k flashes.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2011-03-10 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 14:12 [RFC PATCH] mtd: mxc_nand: fix OOB corruption when page size > 2k Baruch Siach
2011-03-09 14:16 ` Artem Bityutskiy
2011-03-09 14:38 ` Sascha Hauer
2011-03-09 19:22 ` Baruch Siach
2011-03-10 10:08 ` Sascha Hauer
2011-03-10 13:02 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299762179.6676.4.camel@localhost \
--to=dedekind1@gmail.com \
--cc=baruch@tkos.co.il \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox