Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Sergei Poselenov <sposelenov@emcraft.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: UBIFS: file data corruption during the power cut-off test
Date: Fri, 7 Jun 2019 18:02:16 +0200 (CEST)	[thread overview]
Message-ID: <1299833819.84614.1559923336123.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20190607172355.6541fa51@sergmir.emcraft.com>

----- Ursprüngliche Mail -----
> Now, I' overwriting the content of the "test0" with "test2", without "test0"
> truncation:
> mnt/data1 # dd if=test2 of=test0 conv=notrunc
> 222+0 records in
> 222+0 records out
> 113664 bytes (111.0KB) copied, 0.859668 seconds, 129.1KB/s
> /mnt/data1 # md5sum *
> 23376319de62934c3859615e6244aae0  test0
> 23376319de62934c3859615e6244aae0  test1
> 87cd1d1a28896e63eb039d75efef43a3  test2
> /mnt/data1 #
> 
> For this particular test pass, the content of test2 matches the content of the
> original file test0, so overwriting test0 with test2 doesn't change the data.
> 
> However, upon retry of the very same test from the beginning (with the power
> cut-off in the middle) it's easily to have the content of test2 (exactly the
> last 512 bytes in my case) which doesn't match test0, so "dd if=test2 of=test0
> conv=notrunc" will result in test0 with a different checksum.
> 
> To remind, the partition is mounted with the "sync" option.

Ahhh, now understand what you do. Sorry for being dense.

I fear your assumption is not correct because UBIFS is strictly copy-on-write.
So if you overwrite a file, it will always create new data blocks. A data block
has 4k. If you face a power-cut from this 4k block the last written page can be
lost. This is likely what you see.

Does my answer help?

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2019-06-07 16:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  9:10 UBIFS: file data corruption during the power cut-off test Sergei Poselenov
2019-06-06 14:55 ` Richard Weinberger
2019-06-06 18:08   ` Sergei Poselenov
2019-06-06 18:13     ` Richard Weinberger
2019-06-07 14:23       ` Sergei Poselenov
2019-06-07 16:01         ` Steve deRosier
2019-06-09  8:32           ` Sergei Poselenov
2019-06-09 15:25             ` Steve deRosier
2019-06-07 16:02         ` Richard Weinberger [this message]
2019-06-08  6:42           ` Sergei Poselenov
2019-06-08  8:46             ` Richard Weinberger
2019-06-09  8:18               ` Sergei Poselenov
2019-06-09  8:53                 ` Richard Weinberger
2019-06-09  9:59                   ` Sergei Poselenov
2019-06-09 10:00                     ` Richard Weinberger
2019-06-15  7:26                       ` Sergei Poselenov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299833819.84614.1559923336123.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sposelenov@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox