Re: [PATCH 02/02] force module loaded with partitions set

[Artem Bityutskiy <Artem.Bityutskiy@nokia.com>]

On Mon, 2011-03-14 at 09:51 +0800, Yang Ruirui wrote:
> From: Yang Ruirui<ruirui.r.yang@tieto.com>
> 
> partitions can not be set after module loaded, the moduel param mode is 0444.
> 
> this patch force module loaded with param partitions set, if user does not
> set partitions then give out a warning and return -EINVAL
> 
> Signed-off-by: Yang Ruirui<ruirui.r.yang@tieto.com>
> Tested-by: Shao Yanqing<yanqing.shao@tieto.com>
> Tested-by: Xiao Yang<yang.xiao@tieto.com>
> ---
>  drivers/mtd/mtdswap.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> --- mtd-2.6-fc2ff59.orig/drivers/mtd/mtdswap.c	2011-03-14 09:36:09.283329099 +0800
> +++ mtd-2.6-fc2ff59/drivers/mtd/mtdswap.c	2011-03-14 09:46:30.229993534 +0800
> @@ -1569,6 +1569,12 @@ static struct mtd_blktrans_ops mtdswap_o
>  
>  static int __init mtdswap_modinit(void)
>  {
> +	if (!partitions[0]) {
> +		printk(KERN_WARNING
> +			"Please load mtdswap with correct partitions param\n");
> +		return -EINVAL;
> +	}

I think a similar check is done in mtdswap_add_mtd() ?


-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)