From: Artem Bityutskiy <dedekind1@gmail.com>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: MTD list <linux-mtd@lists.infradead.org>
Subject: [PATCH 6/6] UBIFS: save 128KiB or more RAM
Date: Mon, 14 Mar 2011 16:46:12 +0200 [thread overview]
Message-ID: <1300113972-4507-7-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1300113972-4507-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
When debugging is enabled, we allocate a buffer of PEB size for
various debugging purposes. However, now all users of this buffer
are gone and we can safely remove it and save 128KiB or more RAM.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
fs/ubifs/debug.c | 9 ---------
fs/ubifs/debug.h | 2 --
2 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index c2e5c08..01c2b02 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2701,16 +2701,8 @@ int ubifs_debugging_init(struct ubifs_info *c)
if (!c->dbg)
return -ENOMEM;
- c->dbg->buf = vmalloc(c->leb_size);
- if (!c->dbg->buf)
- goto out;
-
failure_mode_init(c);
return 0;
-
-out:
- kfree(c->dbg);
- return -ENOMEM;
}
/**
@@ -2720,7 +2712,6 @@ out:
void ubifs_debugging_exit(struct ubifs_info *c)
{
failure_mode_exit(c);
- vfree(c->dbg->buf);
kfree(c->dbg);
}
diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h
index 10190c1..4efbba7 100644
--- a/fs/ubifs/debug.h
+++ b/fs/ubifs/debug.h
@@ -27,7 +27,6 @@
/**
* ubifs_debug_info - per-FS debugging information.
- * @buf: a buffer of LEB size, used for various purposes
* @old_zroot: old index root - used by 'dbg_check_old_index()'
* @old_zroot_level: old index root level - used by 'dbg_check_old_index()'
* @old_zroot_sqnum: old index root sqnum - used by 'dbg_check_old_index()'
@@ -54,7 +53,6 @@
* dfs_dump_tnc: "dump TNC" debugfs knob
*/
struct ubifs_debug_info {
- void *buf;
struct ubifs_zbranch old_zroot;
int old_zroot_level;
unsigned long long old_zroot_sqnum;
--
1.7.2.3
prev parent reply other threads:[~2011-03-14 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 14:46 [PATCH 0/6] UBIFS: save a bit of RAM Artem Bityutskiy
2011-03-14 14:46 ` [PATCH 1/6] UBIFS: allocate dump buffer on demand Artem Bityutskiy
2011-03-14 14:46 ` [PATCH 2/6] UBIFS: allocate scanning " Artem Bityutskiy
2011-03-14 14:46 ` [PATCH 3/6] UBIFS: allocate ltab checking " Artem Bityutskiy
2011-03-14 14:46 ` [PATCH 4/6] UBIFS: allocate lpt dump " Artem Bityutskiy
2011-03-14 14:46 ` [PATCH 5/6] UBIFS: allocate orphans scan " Artem Bityutskiy
2011-03-14 14:46 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300113972-4507-7-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox