From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, linux@arm.linux.org.uk,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org,
David.Woodhouse@intel.com
Subject: Re: [PATCH 5/7] add GPMI support for imx28
Date: Thu, 31 Mar 2011 12:47:29 +0300 [thread overview]
Message-ID: <1301564849.2828.26.camel@localhost> (raw)
In-Reply-To: <1300240521-4344-6-git-send-email-b32955@freescale.com>
On Wed, 2011-03-16 at 09:55 +0800, Huang Shijie wrote:
> +#define BF_BCH_CTRL_RSVD5(v) \
> + (((v) << 23) & BM_BCH_CTRL_RSVD5)
Many lines where you used "\" fit 80 lines. Just do not use tabs between
name and value (which is ugly, imo), use a space and then it fits 80
lines. This neater than splitting things on 2 lines.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-03-31 9:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 1:55 [PATCH 0/7] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-03-16 1:55 ` [PATCH 1/7] ARM: add GPMI support for imx23/imx28 Huang Shijie
2011-03-16 1:55 ` [PATCH 2/7] add the common code for GPMI driver Huang Shijie
2011-03-16 1:55 ` [PATCH 3/7] add the database for the NANDs Huang Shijie
2011-03-23 15:29 ` Florian Fainelli
2011-03-24 2:27 ` Huang Shijie
2011-03-24 13:50 ` Florian Fainelli
2011-03-25 2:47 ` Huang Shijie
2011-03-25 6:48 ` Lothar Waßmann
2011-03-25 6:59 ` Huang Shijie
2011-03-31 9:54 ` Artem Bityutskiy
2011-03-31 10:09 ` Huang Shijie
2011-03-16 1:55 ` [PATCH 4/7] add GPMI support for imx23 Huang Shijie
2011-03-16 1:55 ` [PATCH 5/7] add GPMI support for imx28 Huang Shijie
2011-03-31 9:47 ` Artem Bityutskiy [this message]
2011-03-31 10:09 ` Huang Shijie
2011-03-31 9:49 ` Artem Bityutskiy
2011-03-31 9:49 ` Artem Bityutskiy
2011-03-16 1:55 ` [PATCH 6/7] dmaengine: change the flags of request_irq() Huang Shijie
2011-03-16 1:55 ` [PATCH 7/7] MTD : add GPMI driver in the config and Makefile Huang Shijie
2011-03-31 9:44 ` Artem Bityutskiy
2011-03-16 7:12 ` [PATCH 0/7] add the GPMI controller driver for IMX23/IMX28 Artem Bityutskiy
2011-03-16 7:30 ` Huang Shijie-B32955
2011-03-22 10:23 ` Huang Shijie
[not found] <1300239773-4222-1-git-send-email-b32955@freescale.com>
[not found] ` <1300239773-4222-6-git-send-email-b32955@freescale.com>
[not found] ` <19848.39439.380861.195051@ipc1.ka-ro>
2011-03-23 3:11 ` [PATCH 5/7] add GPMI support for imx28 Huang Shijie
2011-03-23 14:56 ` Lothar Waßmann
2011-03-23 15:16 ` Florian Fainelli
2011-03-24 3:07 ` Huang Shijie
2011-03-24 3:03 ` Huang Shijie
2011-03-24 7:34 ` Lothar Waßmann
2011-03-24 8:26 ` Jason Liu
2011-03-24 8:32 ` Wolfram Sang
2011-03-24 8:33 ` Lothar Waßmann
2011-03-24 8:51 ` Huang Shijie
2011-03-24 13:54 ` Florian Fainelli
2011-03-25 2:50 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301564849.2828.26.camel@localhost \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).