From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 5/7] add GPMI support for imx28 From: Artem Bityutskiy To: Huang Shijie In-Reply-To: <1300240521-4344-6-git-send-email-b32955@freescale.com> References: <1300240521-4344-1-git-send-email-b32955@freescale.com> <1300240521-4344-6-git-send-email-b32955@freescale.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 31 Mar 2011 12:49:05 +0300 Message-ID: <1301564945.2828.27.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, linux@arm.linux.org.uk, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, David.Woodhouse@intel.com Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2011-03-16 at 09:55 +0800, Huang Shijie wrote: > + pio[0] = > + BF_GPMI_CTRL0_COMMAND_MODE(command_mode) | > + BM_GPMI_CTRL0_WORD_LENGTH | > + BF_GPMI_CTRL0_CS(mil->current_chip) | > + BF_GPMI_CTRL0_ADDRESS(address) | > + BF_GPMI_CTRL0_XFER_COUNT(mil->upper_len); Strange way to format the code ... -- Best Regards, Artem Bityutskiy (Артём Битюцкий)