From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.nokia.com ([147.243.128.24] helo=mgw-da01.nokia.com) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1Q5cbO-0000CP-K6 for linux-mtd@lists.infradead.org; Fri, 01 Apr 2011 11:33:19 +0000 Subject: Re: [PATCH resend] Newly erased page read workaround From: Artem Bityutskiy To: ext Viresh Kumar In-Reply-To: <1301653534-22223-1-git-send-email-viresh.kumar@st.com> References: <1301653534-22223-1-git-send-email-viresh.kumar@st.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 01 Apr 2011 14:30:48 +0300 Message-ID: <1301657448.2789.44.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Vipin Kumar , David.Woodhouse@intel.com, amit.goel@st.com, armando.visconti@st.com, shiraz.hashim@st.com, linux-mtd@lists.infradead.org Reply-To: Artem.Bityutskiy@nokia.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2011-04-01 at 15:55 +0530, ext Viresh Kumar wrote: > + /* > + * This is a temporary erase check. A newly erased page read > + * would result in an ecc error because the oob data is also > + * erased to FF and the calculated ecc for an FF data is not > + * FF..FF. > + * This is a workaround to skip performing correction in case > + * data is FF..FF > + */ Sorry, but still questions. The comment says this is temporary - why? When and how this going to be change to become "permanent". And you still did not add words about the problem with bit-flips. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)