Re: [PATCH] flashcp: improve speed & some clean ups

[Artem Bityutskiy <dedekind1@gmail.com>]

On Thu, 2011-04-07 at 17:04 +0200, Frans Meulenbroeks wrote:
> the speed of the program is improved by:
> - checking if a block needs to be erased before actually erasing it
> - only writing blocks that are not modified
> 
> In order to implement this, the main loop of the program has
> been reworked. I have tried to stay in the style of the
> original author
> 
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

Frans,

any work to improve mtd-utils is appreciated. But the changes should be
sent by small reviewable pieces. I know the feeling when you can't
resist the temptation to re-write whole piece of crap, but we should not
do this.

Please, send separate small patches which do one thing at a time. Do not
hesitate to do even small or massive clean-ups, as long as they are done
in one-type-per-patch. Feel free to change functionality, as long as you
split your work on several nice patches, which can be easily reviewed.
Normal way is to do preparation patches, and then functionality changes.

Thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)