From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1Q9wGX-0000Zy-92 for linux-mtd@lists.infradead.org; Wed, 13 Apr 2011 09:21:37 +0000 Received: by fxm14 with SMTP id 14so408639fxm.36 for ; Wed, 13 Apr 2011 02:21:35 -0700 (PDT) Subject: Re: [PATCH v2] Fix gcc-4.5.2 "statement with no effect" warnings in UBIFS From: Artem Bityutskiy To: Maksim Rayskiy In-Reply-To: References: <1302646496-32261-1-git-send-email-maksim.rayskiy@gmail.com> <1302683190.2768.11.camel@localhost> <1302683341.2768.12.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Wed, 13 Apr 2011 12:18:45 +0300 Message-ID: <1302686325.2768.18.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, vapier.adi@gmail.com Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2011-04-13 at 01:49 -0700, Maksim Rayskiy wrote: > Artem, > > >> This patch does not compile and does not apply to the current tree. I'll > >> need to do a lot of massage as well because I dislike the "tabs as > >> dynamic spaces" style which you use, and the whole UBIFS code does not > >> use this approach, so I would like to maintain consistency. > > > > Sorry, it does compile with older UBIFS, but not with the current one. > > > > > > I checked it against Linus tree. What tree you want me to use? > I am not clear what you want me to do with formatting. Maksim, would you please confirm the patch I pushed to ubifs-2.6.git tree fixes all the gcc-4.5 warnings? -- Best Regards, Artem Bityutskiy (Артём Битюцкий)