* [PATCH] nand: Remove doubled chip deselection on (un)lock
@ 2011-04-13 10:26 Jiri Pinkava
2011-04-14 12:20 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pinkava @ 2011-04-13 10:26 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, Jiri Pinkava, dwmw2, ben-linux
Chip deselection is already done in nand_release_device. So only
duplicate code.
Signed-off-by: Jiri Pinkava <jiri.pinkava@vscht.cz>
---
drivers/mtd/nand/nand_base.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index c54a4cb..bc1c2e6 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -976,9 +976,6 @@ int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
ret = __nand_unlock(mtd, ofs, len, 0);
out:
- /* de-select the NAND device */
- chip->select_chip(mtd, -1);
-
nand_release_device(mtd);
return ret;
@@ -1046,9 +1043,6 @@ int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
ret = __nand_unlock(mtd, ofs, len, 0x1);
out:
- /* de-select the NAND device */
- chip->select_chip(mtd, -1);
-
nand_release_device(mtd);
return ret;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nand: Remove doubled chip deselection on (un)lock
2011-04-13 10:26 [PATCH] nand: Remove doubled chip deselection on (un)lock Jiri Pinkava
@ 2011-04-14 12:20 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2011-04-14 12:20 UTC (permalink / raw)
To: Jiri Pinkava; +Cc: linux-mtd, dwmw2, ben-linux
On Wed, 2011-04-13 at 12:26 +0200, Jiri Pinkava wrote:
> Chip deselection is already done in nand_release_device. So only
> duplicate code.
>
> Signed-off-by: Jiri Pinkava <jiri.pinkava@vscht.cz>
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-14 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-13 10:26 [PATCH] nand: Remove doubled chip deselection on (un)lock Jiri Pinkava
2011-04-14 12:20 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).