From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Turner <admin@islandsoftware.co.uk>
Cc: linux-mtd@lists.infradead.org
Subject: Re: bug found in the core MTD driver code in 2.6.34 r97
Date: Mon, 18 Apr 2011 07:38:08 +0300 [thread overview]
Message-ID: <1303101488.2815.2.camel@localhost> (raw)
In-Reply-To: <165001cbfac4$c10056b0$0400a8c0@hack>
On Thu, 2011-04-14 at 17:55 +0100, Mike Turner wrote:
> Hi folks,
>
> On the second and subsequent boots into my Gumstix NAND-resident ubifs RFS
> (Gumstix "minimal build" aimed at fast booting from NAND), it seems that
> udevadm - executing from the script /etc/init.d/udev - encounters a driver
> crash when drivers/mtd/ubi/gluebi.c:gluebi_read() passes the value
> 0xFFFFFFF0 as a "struct ubi_volume_desc *" argument to ubi_read() and
> thence ubi_leb_read().
OK, I see the issue now.
> Is this bug unique to my build, perhaps caused by an
> incomplete/wrong/missing patch, or is it the case in other builds?
Not this is just a bug. Your version of the kernel is old and the
upstream has changed, but I see there are problems with the error path
in upstream as well.
>
> I fixed it by making blktrans_open() behave exactly the same w.r.t. the
> return from get_mtd_device() as do all the other callers to that function.
> I presume that would be the correct approach?
Yeah, you may just fix up your kernel. You might as well try the
upstream kernel, fix it and submit a patch.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2011-04-18 4:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 16:55 bug found in the core MTD driver code in 2.6.34 r97 Mike Turner
2011-04-18 4:27 ` Artem Bityutskiy
2011-04-18 4:38 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303101488.2815.2.camel@localhost \
--to=dedekind1@gmail.com \
--cc=admin@islandsoftware.co.uk \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox