From: Artem Bityutskiy <dedekind1@gmail.com>
To: Nicholas <ciliwung36@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: UBI memory usage on large page nand
Date: Wed, 20 Apr 2011 10:30:33 +0300 [thread overview]
Message-ID: <1303284633.2700.3.camel@localhost> (raw)
In-Reply-To: <BANLkTim2aXQY5YzJkadHWT_NQ2XNupTHBA@mail.gmail.com>
Hi,
On Wed, 2011-04-20 at 11:19 +0800, Nicholas wrote:
> Dear Artem,
>
> Sorry for my late reply .
Please, send proper Linux kernel patches. Hints:
1. Make a separate patch pere change, so that on modification is done by
one patch. In your case, one buffer improvement pere patch.
2. Write good commit message.
3. Use git format-patch to create patches.
>
> #define MTD_SMALL_SIZE_PAGE_BLOCK_SIZE 0x40000 // block size for 2KB
No, please just make buffer size to be ubi->max_write_size. Kill this
constant.
> orphan.c
> In ubifs_mount_orphans()
> c->orph_buf = vmalloc((c->leb_size)/4); // for temporary
Similarly, just use ubi->max_write_size instead.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-04-20 7:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTi=GsmJOjurETG930t-TW7uXLR1M6yKXWBSk7ebV@mail.gmail.com>
2011-03-31 3:07 ` UBI memory usage on large page nand Nicholas
2011-04-01 15:31 ` Artem Bityutskiy
2011-04-15 9:23 ` Nicholas
2011-04-15 13:13 ` Artem Bityutskiy
2011-04-15 13:17 ` Artem Bityutskiy
2011-04-15 13:24 ` Artem Bityutskiy
2011-04-17 9:03 ` Nicholas
2011-04-17 9:16 ` Artem Bityutskiy
2011-04-18 8:29 ` Nicholas
2011-04-18 8:39 ` Artem Bityutskiy
2011-04-20 3:19 ` Nicholas
2011-04-20 7:30 ` Artem Bityutskiy [this message]
2011-08-17 6:35 ` Nicholas
2011-08-20 5:17 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303284633.2700.3.camel@localhost \
--to=dedekind1@gmail.com \
--cc=ciliwung36@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox