linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/5] UBIFS: remove strange commentary
@ 2011-04-24 13:26 Artem Bityutskiy
  2011-04-25 10:51 ` Atlant Schmidt
  0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2011-04-24 13:26 UTC (permalink / raw)
  To: MTD list

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Remove the following commentary from 'ubifs_file_mmap()':

/* 'generic_file_mmap()' takes care of NOMMU case */

I do not understand what it means, and I could not find anything relater to
NOMMU in 'generic_file_mmap()'.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/file.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index adce3b7..5e7fccf 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1541,7 +1541,6 @@ static int ubifs_file_mmap(struct file *file, struct vm_area_struct *vma)
 {
 	int err;
 
-	/* 'generic_file_mmap()' takes care of NOMMU case */
 	err = generic_file_mmap(file, vma);
 	if (err)
 		return err;
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH 4/5] UBIFS: remove strange commentary
  2011-04-24 13:26 [PATCH 4/5] UBIFS: remove strange commentary Artem Bityutskiy
@ 2011-04-25 10:51 ` Atlant Schmidt
  2011-04-25 12:12   ` Artem Bityutskiy
  0 siblings, 1 reply; 3+ messages in thread
From: Atlant Schmidt @ 2011-04-25 10:51 UTC (permalink / raw)
  To: 'Artem Bityutskiy', MTD list


Folks:

> /* 'generic_file_mmap()' takes care of NOMMU case */
>
> I do not understand what it means,

  It sounds like there must be / must have been code
  to handle memory mapping in systems that do not
  have a Memory Management Unit (an MMU providing
  virtual-to-physical address translation).

                         Atlant

-----Original Message-----
From: linux-mtd-bounces@lists.infradead.org [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf Of Artem Bityutskiy
Sent: Sunday, April 24, 2011 09:26
To: MTD list
Subject: [PATCH 4/5] UBIFS: remove strange commentary

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Remove the following commentary from 'ubifs_file_mmap()':

/* 'generic_file_mmap()' takes care of NOMMU case */

I do not understand what it means, and I could not find anything relater to
NOMMU in 'generic_file_mmap()'.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/file.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index adce3b7..5e7fccf 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1541,7 +1541,6 @@ static int ubifs_file_mmap(struct file *file, struct vm_area_struct *vma)
 {
        int err;

-       /* 'generic_file_mmap()' takes care of NOMMU case */
        err = generic_file_mmap(file, vma);
        if (err)
                return err;
--
1.7.2.3


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

This e-mail and the information, including any attachments, it contains are intended to be a confidential communication only to the person or entity to whom it is addressed and may contain information that is privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender and destroy the original message.

Thank you.

Please consider the environment before printing this email.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH 4/5] UBIFS: remove strange commentary
  2011-04-25 10:51 ` Atlant Schmidt
@ 2011-04-25 12:12   ` Artem Bityutskiy
  0 siblings, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2011-04-25 12:12 UTC (permalink / raw)
  To: Atlant Schmidt; +Cc: MTD list

On Mon, 2011-04-25 at 06:51 -0400, Atlant Schmidt wrote:
> Folks:
> 
> > /* 'generic_file_mmap()' takes care of NOMMU case */
> >
> > I do not understand what it means,
> 
>   It sounds like there must be / must have been code
>   to handle memory mapping in systems that do not
>   have a Memory Management Unit (an MMU providing
>   virtual-to-physical address translation).

Yes, must be "must have been" :-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-04-25 12:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-24 13:26 [PATCH 4/5] UBIFS: remove strange commentary Artem Bityutskiy
2011-04-25 10:51 ` Atlant Schmidt
2011-04-25 12:12   ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).