From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: add switch to support NAND flash on big endian bus
Date: Tue, 26 Apr 2011 13:10:25 +0200 [thread overview]
Message-ID: <1303816225.3125.3.camel@hcegtvedt> (raw)
In-Reply-To: <1302784536.2796.34.camel@localhost>
On Thu, 2011-04-14 at 15:35 +0300, Artem Bityutskiy wrote:
> On Wed, 2011-04-13 at 15:55 +0200, Hans-Christian Egtvedt wrote:
> > This patch adds a new kconfig symbol to the MTD NAND system, MTD_NAND_BE_BUS.
> > This symbol is used by the nand base to properly convert the data read from the
> > bus into the format the CPU expects.
> >
> > The patch fixes 16-bit NAND flash support on big endian architectures (at least
> > AVR32) with NAND flash hooked up to a big endian external bus.
> >
> > Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
>
> These kind of config options are bad and lead to confusion. You should
> try hard to auto-detect the endianness, or take this information from
> the boot-loader via the device tree.
AVR32 doesn't support the device tree.
For AVR32 assuming big endian wiring on the EBI is sane, as the
architecture is big-endian only. I don't know how other big endian
architectures behaves, and I am puzzled that I am the only observer of
this...
--
Hans-Christian Egtvedt
next prev parent reply other threads:[~2011-04-26 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 13:55 [PATCH 1/2] atmel_nand: add missing include of linux/dmaengine.h Hans-Christian Egtvedt
2011-04-13 13:55 ` [PATCH 2/2] mtd: add switch to support NAND flash on big endian bus Hans-Christian Egtvedt
2011-04-13 14:11 ` Ricard Wanderlof
2011-04-26 11:23 ` Hans-Christian Egtvedt
2011-04-14 12:35 ` Artem Bityutskiy
2011-04-26 11:10 ` Hans-Christian Egtvedt [this message]
2011-04-14 13:39 ` [PATCH 1/2] atmel_nand: add missing include of linux/dmaengine.h Artem Bityutskiy
2011-04-14 14:01 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303816225.3125.3.camel@hcegtvedt \
--to=hans-christian.egtvedt@atmel.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox