Re: [PATCH] UBIFS: add the fixup function

[Artem Bityutskiy <dedekind1@gmail.com>]

On Fri, 2011-05-06 at 18:13 +0300, Artem Bityutskiy wrote:
> From: Matthew L. Creech <mlcreech@gmail.com>
> 
> This patch adds the 'ubifs_fixup_free_space()' function which scans all LEBs in
> the filesystem for those that are in-use but have one or more empty pages, then
> re-maps the LEBs in order to erase the empty portions.  Afterward it removes
> the "space_fixup" flag from the UBIFS superblock.
> 
> Artem: amended the commit message, massage the patch, fix few minor things
> there.
> 
> Signed-off-by: Matthew L. Creech <mlcreech@gmail.com>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

This is your patch N2 but with many of my changes and amendments. I've
added the code which should take care of the log LEBs - completely
untested. I've amended comments - I did not like the word "remap" you
used - better use "fixup" for that thing, I did not like the word "page"
you used - better use min. I/O unit, unless we are speaking specifically
about NAND. I've removed some comments and added some new, massaged the
code, changed those other things which I wrote about (not touching the
other SB bits, kfree, etc).

Also, we use "UBIFS:" (capital letters) prefix for patches. Could you
please take a look and if you do not have strong disagreements then
amend _this_ version of patch, test it and probably fix, and then send
the whole series again. Note, patch N1 is already in my tree, so unless
you need to change it - you do not have to send it.

Thanks! Sorry for messy replies, I'm (as always) busy and trying to do
as much as I can during the little time I have :-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)