public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Matthew L. Creech" <mlcreech@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 2/3] ubifs: add ubifs_fixup_free_space()
Date: Fri, 06 May 2011 18:17:05 +0300	[thread overview]
Message-ID: <1304695025.7222.76.camel@localhost> (raw)
In-Reply-To: <BANLkTikgYvy9Dk8NXnmUP+1bWAjfoB-LVw@mail.gmail.com>

On Fri, 2011-05-06 at 11:18 -0400, Matthew L. Creech wrote:
> On Fri, May 6, 2011 at 11:02 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> >> +
> >> +     ubifs_assert(len >= 0);
> >> +     ubifs_assert(len % c->min_io_size == 0);
> >
> > So if this is true.
> >
> >> +
> >> +     /* Pad if necessary */
> >> +     aligned_len = ALIGN(len, c->min_io_size);
> >> +     if (aligned_len > len) {
> >
> > This will be always false and the below code can be removed, right?
> >
> 
> Oh, yes you're right - I added it before you had mentioned that the
> lengths would be min_io_size-aligned.  :)  Thanks

I think I killed this in the version of this patch I sent you, I
encourage you to take it as the base for you next version of the
patch-set.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

      reply	other threads:[~2011-05-06 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 20:33 [PATCH v3 2/3] ubifs: add ubifs_fixup_free_space() Matthew L. Creech
2011-05-06 15:02 ` Artem Bityutskiy
2011-05-06 15:18   ` Matthew L. Creech
2011-05-06 15:17     ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304695025.7222.76.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mlcreech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox