linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Atlant Schmidt <aschmidt@dekaresearch.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"Matthew L. Creech" <mlcreech@gmail.com>
Subject: RE: [PATCH 2/2] UBIFS: fix-up free space on mount if flag is set
Date: Fri, 13 May 2011 15:29:25 +0300	[thread overview]
Message-ID: <1305289765.14423.20.camel@localhost> (raw)
In-Reply-To: <0A40042D85E7C84DB443060EC44B3FD32A694157DD@dekaexchange07.deka.local>

Hi,

On Fri, 2011-05-13 at 06:59 -0400, Atlant Schmidt wrote:
> Artem:
> 
>   I don't know what the coding standards are like on
>   your project,

The kenrel standard, described in Documentation/CodingStyle

>  but in very much of the C/C++ developer
>   world, <tab>s are frowned upon in code as being fragile,
>   primarily because there are varying standards for just
>   how wide a <tab> should be.

In the kernel we just stand that it must be 8 spaces.

>  By default, they're 8 spaces,
>   but I've worked at several shops where they are only
>   4 spaces and one shop where they are deemed to be 3!

Well, there were many flamewars about this, but we just assume that
anyone looking at the kernel source code has to setup their editors to
have tab=8 spaces.

>   Because of this, many coding standards (such as the
>   WebKit coding standards and my current employer's
>   standard) outright ban <tab> characters in code and
>   I'd recommend you do so as well, no matter what the
>   current scripts enforce. (It's certainly easy enough
>   to expand all the tabs in an existing code base so
>   as to bring it into compliance with a "no tabs" rule.)

Well, UBIFS is part of the kernel and it follows the kernel coding
style.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

  parent reply	other threads:[~2011-05-13 12:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 22:58 [PATCH 0/2] UBIFS: Free space fixup on first mount Matthew L. Creech
2011-05-06 22:58 ` [PATCH 1/2] UBIFS: add the fixup function Matthew L. Creech
2011-05-12 10:33   ` Artem Bityutskiy
2011-05-18 20:47     ` [PATCH] UBIFS: don't fail on -EBADMSG when fixing free space Ben Gardiner
2011-05-18 21:41       ` Matthew L. Creech
2011-05-19 13:28         ` Ben Gardiner
2011-05-19 15:59           ` Matthew L. Creech
2011-05-20  6:21           ` Artem Bityutskiy
2011-05-20  6:29           ` Artem Bityutskiy
2011-05-24 14:33             ` Ben Gardiner
2011-05-06 22:58 ` [PATCH 2/2] UBIFS: fix-up free space on mount if flag is set Matthew L. Creech
2011-05-12 10:57   ` Artem Bityutskiy
2011-05-19  5:32     ` [PATCH] UBIFS: document the "free space fixup" flag Matthew L. Creech
2011-05-20  9:24       ` Artem Bityutskiy
2011-05-12 11:09   ` [PATCH 2/2] UBIFS: fix-up free space on mount if flag is set Artem Bityutskiy
2011-05-13  7:58     ` Artem Bityutskiy
2011-05-13 10:59       ` Atlant Schmidt
2011-05-13 12:02         ` Michael Cashwell
2011-05-13 12:29         ` Artem Bityutskiy [this message]
2011-05-13 12:34           ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305289765.14423.20.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=aschmidt@dekaresearch.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mlcreech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).