Re: [PATCH v5 1/8] MTD: Add integrator-flash feature to physmap

Marc Zyngier
2011-05-17T08:48:24Z

On Tue, 2011-05-17 at 11:13 +0300, Artem Bityutskiy wrote:
> On Tue, 2011-05-17 at 08:43 +0100, Russell King - ARM Linux wrote:
> > On Tue, May 17, 2011 at 08:46:18AM +0300, Artem Bityutskiy wrote:
> > > On Tue, 2011-05-17 at 08:37 +0300, Artem Bityutskiy wrote:
> > > > Sorry if this sounds like an attack, it is not. I just think that we
> > > > carry crap for too long and should start forcing people to clean it up
> > > > by not accepting changes :-)
> > >
> > > Sorry, I forgot to note that I do not insist that you have to re-work
> > > MTD partitions support - you already do a very good thing by killing a
> > > redundant driver, and delaying this would be counter-productive. But I
> > > anyway wanted to express my thoughts.
> >
> > So, what's happening with this patch set? I'd like to have an ack from
> > the MTD people for the set.
>
> David should answer, but from my POW the patches are OK. The "#ifdef
> CONFIG_MTD_AFS_PARTS" is ugly. I think it can be just killed, it just
> needs an additional patch to silence the kernel (completely untested,
> Marc, could you please check it?):

Looks OK to me, as long as people don't miss the information (could make
the "where's my partition gone?" question harder to answer...).

As this change is orthogonal to mine, I suggest this change goes via the
MTD tree, independently from this patch set. I post a v6 later today
(without the #ifdef-ery).

Cheers,

M.
--
Reality is an implementation detail.