From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: linux-mtd@lists.infradead.org, "Matthew L. Creech" <mlcreech@gmail.com>
Subject: Re: [PATCH v2] mkfs.ubifs: free-space-fixup: note supported kernels
Date: Fri, 20 May 2011 13:15:45 +0300 [thread overview]
Message-ID: <1305886545.2630.129.camel@localhost> (raw)
In-Reply-To: <1305807291-12774-1-git-send-email-bengardiner@nanometrics.ca>
Hi,
On Thu, 2011-05-19 at 08:14 -0400, Ben Gardiner wrote:
> *
> * UBIFS_FLG_BIGLPT: if "big" LPT model is used if set
> * UBIFS_FLG_SPACE_FIXUP: first-mount "fixup" of free space within LEBs needed
> + * the free space fixup will be performed only by kernel
> + * releases 2.6.40 or greater.
> */
Since this is kind of an out-of-date copy of the kernel header file,
this change is not needed because it'll anyway go away when someone
syncs ubifs-media.h with the kernel.
After my changes to Matthew's patch and tweaks to your patch I've found
out that it is cleaner to just fold your patch into Mathew's and make
one single commit. I've thanked you in the commit message and pushed one
single commit instead:
http://git.infradead.org/mtd-utils.git/commit/04665066ebedb0a31335b525fb5f19df32cb8cfe
Hopefully you will not mind.
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-05-20 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 22:14 [PATCH v2] mkfs.ubifs: add "-F" option for "free-space fixup" Matthew L. Creech
2011-05-11 20:09 ` Ben Gardiner
2011-05-11 21:01 ` Matthew L. Creech
2011-05-11 21:02 ` [PATCH 1/1] " Matthew L. Creech
2011-05-12 13:13 ` Artem Bityutskiy
2011-05-18 20:57 ` [PATCH] mkfs.ubifs: free-space-fixup: note supported kernels Ben Gardiner
2011-05-19 5:41 ` Matthew L. Creech
2011-05-19 5:56 ` Artem Bityutskiy
2011-05-19 12:14 ` [PATCH v2] " Ben Gardiner
2011-05-20 10:15 ` Artem Bityutskiy [this message]
2011-05-24 14:36 ` Ben Gardiner
2011-05-20 10:11 ` [PATCH 1/1] mkfs.ubifs: add "-F" option for "free-space fixup" Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305886545.2630.129.camel@localhost \
--to=dedekind1@gmail.com \
--cc=bengardiner@nanometrics.ca \
--cc=linux-mtd@lists.infradead.org \
--cc=mlcreech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).