From: Artem Bityutskiy <dedekind1@gmail.com>
To: maxin <john.maxin@nokia.com>
Cc: Jarkko Lavinen <jarkko.lavinen@nokia.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] drivers: mtd: mtdswap: fix possible null dereference
Date: Fri, 20 May 2011 15:08:08 +0300 [thread overview]
Message-ID: <1305893288.2630.141.camel@localhost> (raw)
In-Reply-To: <4DD66B11.4070605@nokia.com>
On Fri, 2011-05-20 at 14:22 +0100, maxin wrote:
> This patch fixes the possible null dereference of the variable "oinfo"
> Thanks to Coverity for spotting this.
>
> Signed-off-by: Maxin B. John <john.maxin@nokia.com>
> ---
> diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
> index fed215c..62ddb3a 100644
> --- a/drivers/mtd/mtdswap.c
> +++ b/drivers/mtd/mtdswap.c
> @@ -1450,7 +1450,13 @@ static void mtdswap_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
> }
>
> oinfo = mtd->ecclayout;
> - if (!mtd->oobsize || !oinfo || oinfo->oobavail < MTDSWAP_OOBSIZE) {
> + if (!oinfo) {
> + printk(KERN_ERR "%s: mtd%d does not have OOB"
> + "\n", MTDSWAP_PREFIX, mtd->index);
Sorry for not noticing this immediately, but we never split the strings
if it is not really necessary. What is the fundamental reason to put
"\n" separately?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-05-20 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 12:00 [PATCH] drivers: mtd: mtdswap: fix possible null dereference maxin
2011-05-20 5:46 ` Artem Bityutskiy
2011-05-20 11:54 ` maxin
2011-05-20 10:20 ` Artem Bityutskiy
2011-05-20 13:22 ` maxin
2011-05-20 12:08 ` Artem Bityutskiy [this message]
2011-05-20 14:34 ` Maxin B. John
2011-05-20 12:10 ` Artem Bityutskiy
2011-05-20 14:44 ` Maxin B. John
2011-05-20 12:47 ` Artem Bityutskiy
2011-05-20 13:51 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305893288.2630.141.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jarkko.lavinen@nokia.com \
--cc=john.maxin@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).