* [PATCH -next] mtd: fix physmap.h warnings
[not found] <20110523154518.5e27cfb0.sfr@canb.auug.org.au>
@ 2011-05-23 18:37 ` Randy Dunlap
2011-05-24 5:53 ` Artem Bityutskiy
2011-05-24 7:41 ` Artem Bityutskiy
0 siblings, 2 replies; 9+ messages in thread
From: Randy Dunlap @ 2011-05-23 18:37 UTC (permalink / raw)
To: Stephen Rothwell, linux-mtd; +Cc: linux-next, David Woodhouse, LKML
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix build warnings in physmap.h:
include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/linux/mtd/physmap.h | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110523.orig/include/linux/mtd/physmap.h
+++ linux-next-20110523/include/linux/mtd/physmap.h
@@ -19,6 +19,7 @@
#include <linux/mtd/partitions.h>
struct map_info;
+struct platform_device;
struct physmap_flash_data {
unsigned int width;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-23 18:37 ` [PATCH -next] mtd: fix physmap.h warnings Randy Dunlap
@ 2011-05-24 5:53 ` Artem Bityutskiy
2011-05-24 5:58 ` Artem Bityutskiy
2011-05-24 7:41 ` Artem Bityutskiy
1 sibling, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2011-05-24 5:53 UTC (permalink / raw)
To: Randy Dunlap, Russell King
Cc: Stephen Rothwell, Marc Zyngier, LKML, linux-next, linux-mtd,
David Woodhouse
On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix build warnings in physmap.h:
>
> include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
> include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
> include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Oh, this was missed during review. This was introduced in
b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's
tree, so I guess Russel could pick up your patch.
CCed relevant people.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-24 5:53 ` Artem Bityutskiy
@ 2011-05-24 5:58 ` Artem Bityutskiy
2011-05-24 7:40 ` Russell King
0 siblings, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2011-05-24 5:58 UTC (permalink / raw)
To: Russell King
Cc: Randy Dunlap, Stephen Rothwell, Marc Zyngier, LKML, linux-next,
linux-mtd, David Woodhouse
On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote:
> On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Fix build warnings in physmap.h:
> >
> > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
> > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
> > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
> > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Oh, this was missed during review. This was introduced in
> b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's
> tree, so I guess Russel could pick up your patch.
My big apologies, s/Russel/Russell/.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-24 5:58 ` Artem Bityutskiy
@ 2011-05-24 7:40 ` Russell King
2011-05-24 7:40 ` Artem Bityutskiy
2011-05-24 7:42 ` Artem Bityutskiy
0 siblings, 2 replies; 9+ messages in thread
From: Russell King @ 2011-05-24 7:40 UTC (permalink / raw)
To: Artem Bityutskiy
Cc: Randy Dunlap, Stephen Rothwell, Marc Zyngier, LKML, linux-next,
linux-mtd, David Woodhouse
On Tue, May 24, 2011 at 08:58:03AM +0300, Artem Bityutskiy wrote:
> On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote:
> > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Fix build warnings in physmap.h:
> > >
> > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
> > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
> > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
> > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Oh, this was missed during review. This was introduced in
> > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's
> > tree, so I guess Russel could pick up your patch.
>
> My big apologies, s/Russel/Russell/.
Which patch? Neither of these messages contained Randy's patch and I
wasn't included on the original posting.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-24 7:40 ` Russell King
@ 2011-05-24 7:40 ` Artem Bityutskiy
2011-05-24 7:42 ` Artem Bityutskiy
1 sibling, 0 replies; 9+ messages in thread
From: Artem Bityutskiy @ 2011-05-24 7:40 UTC (permalink / raw)
To: Russell King
Cc: Randy Dunlap, Stephen Rothwell, Marc Zyngier, LKML, linux-next,
linux-mtd, David Woodhouse
On Tue, 2011-05-24 at 08:40 +0100, Russell King wrote:
> On Tue, May 24, 2011 at 08:58:03AM +0300, Artem Bityutskiy wrote:
> > On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote:
> > > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > >
> > > > Fix build warnings in physmap.h:
> > > >
> > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
> > > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
> > > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
> > > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
> > > >
> > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Oh, this was missed during review. This was introduced in
> > > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's
> > > tree, so I guess Russel could pick up your patch.
> >
> > My big apologies, s/Russel/Russell/.
>
> Which patch? Neither of these messages contained Randy's patch and I
> wasn't included on the original posting.
Sorry, I assumed you'd look that lkml is in CC and would find it in lkml
(I assumed you are subscribed there). I'll send this patch shortly.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-23 18:37 ` [PATCH -next] mtd: fix physmap.h warnings Randy Dunlap
2011-05-24 5:53 ` Artem Bityutskiy
@ 2011-05-24 7:41 ` Artem Bityutskiy
1 sibling, 0 replies; 9+ messages in thread
From: Artem Bityutskiy @ 2011-05-24 7:41 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, linux-mtd, David Woodhouse, LKML
From: Randy Dunlap <randy.dunlap@oracle.com>
Subject: [PATCH] mtd: fix physmap.h warnings
Fix build warnings in physmap.h:
include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
include/linux/mtd/physmap.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
index 49b9590..697cc98 100644
--- a/include/linux/mtd/physmap.h
+++ b/include/linux/mtd/physmap.h
@@ -19,6 +19,7 @@
#include <linux/mtd/partitions.h>
struct map_info;
+struct platform_device;
struct physmap_flash_data {
unsigned int width;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-24 7:40 ` Russell King
2011-05-24 7:40 ` Artem Bityutskiy
@ 2011-05-24 7:42 ` Artem Bityutskiy
2011-06-01 7:45 ` Artem Bityutskiy
1 sibling, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2011-05-24 7:42 UTC (permalink / raw)
To: Russell King
Cc: Randy Dunlap, Stephen Rothwell, Marc Zyngier, LKML, linux-next,
linux-mtd, David Woodhouse
From: Randy Dunlap <randy.dunlap@oracle.com>
Subject: [PATCH] mtd: fix physmap.h warnings
Fix build warnings in physmap.h:
include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
include/linux/mtd/physmap.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
index 49b9590..697cc98 100644
--- a/include/linux/mtd/physmap.h
+++ b/include/linux/mtd/physmap.h
@@ -19,6 +19,7 @@
#include <linux/mtd/partitions.h>
struct map_info;
+struct platform_device;
struct physmap_flash_data {
unsigned int width;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-05-24 7:42 ` Artem Bityutskiy
@ 2011-06-01 7:45 ` Artem Bityutskiy
2011-06-01 8:05 ` Russell King
0 siblings, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2011-06-01 7:45 UTC (permalink / raw)
To: David Woodhouse
Cc: Randy Dunlap, Stephen Rothwell, Marc Zyngier, LKML, linux-next,
linux-mtd, David Woodhouse, Russell King
On Tue, 2011-05-24 at 10:42 +0300, Artem Bityutskiy wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Subject: [PATCH] mtd: fix physmap.h warnings
>
> Fix build warnings in physmap.h:
>
> include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
> include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
> include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
David, it looks like Russel did not merge this patch and people
complain. Could you please merge it?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] mtd: fix physmap.h warnings
2011-06-01 7:45 ` Artem Bityutskiy
@ 2011-06-01 8:05 ` Russell King
0 siblings, 0 replies; 9+ messages in thread
From: Russell King @ 2011-06-01 8:05 UTC (permalink / raw)
To: Artem Bityutskiy
Cc: Randy Dunlap, Stephen Rothwell, Marc Zyngier, LKML, linux-next,
linux-mtd, David Woodhouse
On Wed, Jun 01, 2011 at 10:45:54AM +0300, Artem Bityutskiy wrote:
> On Tue, 2011-05-24 at 10:42 +0300, Artem Bityutskiy wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > Subject: [PATCH] mtd: fix physmap.h warnings
> >
> > Fix build warnings in physmap.h:
> >
> > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list
> > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want
> > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list
> > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> David, it looks like Russel did not merge this patch and people
^^
> complain. Could you please merge it?
Bah, it got lost in the depths of my mailboxes and forgotten...
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-06-01 8:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110523154518.5e27cfb0.sfr@canb.auug.org.au>
2011-05-23 18:37 ` [PATCH -next] mtd: fix physmap.h warnings Randy Dunlap
2011-05-24 5:53 ` Artem Bityutskiy
2011-05-24 5:58 ` Artem Bityutskiy
2011-05-24 7:40 ` Russell King
2011-05-24 7:40 ` Artem Bityutskiy
2011-05-24 7:42 ` Artem Bityutskiy
2011-06-01 7:45 ` Artem Bityutskiy
2011-06-01 8:05 ` Russell King
2011-05-24 7:41 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).