From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: linux-mtd@lists.infradead.org
Subject: [PATCH 041/104] mtd: prepare to convert of_mtd_parse_partitions to partition parser
Date: Thu, 2 Jun 2011 18:51:19 +0400 [thread overview]
Message-ID: <1307026293-8535-7-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1307026293-8535-1-git-send-email-dbaryshkov@gmail.com>
Prepare to convert of_mtd_parse_partitions() to usual partitions parser:
1) Register ofpart parser
2) Internally don't use passed device for error printing
3) Add device_node to mtd_info struct
4) Move of_mtd_parse_partitions from __devinit to common text section
5) add ofpart to the default list of partition parsers
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/mtd/mtdcore.c | 9 +++++++++
drivers/mtd/mtdpart.c | 2 +-
drivers/mtd/ofpart.c | 30 ++++++++++++++++++++++++++++--
include/linux/mtd/mtd.h | 3 +++
include/linux/mtd/partitions.h | 2 +-
5 files changed, 42 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index c510aff..bfd5a65 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -36,6 +36,7 @@
#include <linux/idr.h>
#include <linux/backing-dev.h>
#include <linux/gfp.h>
+#include <linux/of.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
@@ -446,6 +447,10 @@ int mtd_device_register(struct mtd_info *master,
const struct mtd_partition *parts,
int nr_parts)
{
+#ifdef CONFIG_OF
+ if (master->node)
+ of_node_get(master->node);
+#endif
return parts ? add_mtd_partitions(master, parts, nr_parts) :
add_mtd_device(master);
}
@@ -461,6 +466,10 @@ int mtd_device_unregister(struct mtd_info *master)
{
int err;
+#ifdef CONFIG_OF
+ if (master->node)
+ of_node_put(master->node);
+#endif
err = del_mtd_partitions(master);
if (err)
return err;
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 3477e16..0b473ec 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -712,7 +712,7 @@ int deregister_mtd_parser(struct mtd_part_parser *p)
}
EXPORT_SYMBOL_GPL(deregister_mtd_parser);
-static const char *default_mtd_part_types[] = {"cmdlinepart", NULL};
+static const char *default_mtd_part_types[] = {"cmdlinepart", "ofpart", NULL};
int parse_mtd_partitions(struct mtd_info *master, const char **types,
struct mtd_partition **pparts, unsigned long origin)
diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
index a996718..ff11b85 100644
--- a/drivers/mtd/ofpart.c
+++ b/drivers/mtd/ofpart.c
@@ -20,7 +20,20 @@
#include <linux/slab.h>
#include <linux/mtd/partitions.h>
-int __devinit of_mtd_parse_partitions(struct device *dev,
+static int parse_ofpart_partitions(struct mtd_info *master,
+ struct mtd_partition **pparts,
+ unsigned long origin)
+{
+ struct device_node *node;
+
+ node = master->node;
+ if (!node)
+ return 0;
+
+ return of_mtd_parse_partitions(NULL, node, pparts);
+}
+
+int of_mtd_parse_partitions(struct device *dev,
struct device_node *node,
struct mtd_partition **pparts)
{
@@ -69,7 +82,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
if (!i) {
of_node_put(pp);
- dev_err(dev, "No valid partition found on %s\n", node->full_name);
+ pr_err("No valid partition found on %s\n", node->full_name);
kfree(*pparts);
*pparts = NULL;
return -EINVAL;
@@ -79,4 +92,17 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
}
EXPORT_SYMBOL(of_mtd_parse_partitions);
+static struct mtd_part_parser ofpart_parser = {
+ .owner = THIS_MODULE,
+ .parse_fn = parse_ofpart_partitions,
+ .name = "ofpart",
+};
+
+static int __init ofpart_parser_init(void)
+{
+ return register_mtd_parser(&ofpart_parser);
+}
+
+module_init(ofpart_parser_init);
+
MODULE_LICENSE("GPL");
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 2541fb8..14305d0 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -171,6 +171,9 @@ struct mtd_info {
// Kernel-only stuff starts here.
const char *name;
int index;
+#ifdef CONFIG_OF
+ struct device_node *node;
+#endif
/* ecc layout structure pointer - read only ! */
struct nand_ecclayout *ecclayout;
diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h
index 08c9c7b..5fde0d8 100644
--- a/include/linux/mtd/partitions.h
+++ b/include/linux/mtd/partitions.h
@@ -71,7 +71,7 @@ struct device;
struct device_node;
#ifdef CONFIG_MTD_OF_PARTS
-int __devinit of_mtd_parse_partitions(struct device *dev,
+int of_mtd_parse_partitions(struct device *dev,
struct device_node *node,
struct mtd_partition **pparts);
#else
--
1.7.4.4
next prev parent reply other threads:[~2011-06-02 14:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 14:51 [RFC PATCH 000/104] mtd: cleanup partition parsing interface Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 004/104] mtd: drop physmap_configure Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 005/104] mtd: cafe_nand: drop reference to CONFIG_MTD_CMDLINE_PARTS Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 006/104] mtdpart: default to cmdlinepart, NULL partitions probing Dmitry Eremin-Solenikov
2011-06-06 7:14 ` Artem Bityutskiy
2011-06-02 14:51 ` [PATCH 007/104] mtd: m25p80 don't specify default parsing options Dmitry Eremin-Solenikov
2011-06-06 7:20 ` Artem Bityutskiy
2011-06-02 14:51 ` [PATCH 040/104] mtd: drop mtd_has_cmdlinepart() Dmitry Eremin-Solenikov
2011-06-06 7:23 ` Artem Bityutskiy
2011-06-02 14:51 ` Dmitry Eremin-Solenikov [this message]
2011-06-06 7:57 ` [PATCH 041/104] mtd: prepare to convert of_mtd_parse_partitions to partition parser Artem Bityutskiy
2011-06-06 8:15 ` Dmitry Eremin-Solenikov
2011-06-06 8:19 ` Artem Bityutskiy
2011-06-06 10:10 ` Dmitry Eremin-Solenikov
2011-06-06 8:05 ` Artem Bityutskiy
2011-06-06 9:21 ` Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 042/104] mtd: m25p80: use ofpart through generic parsing Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 043/104] mtd: physmap_of: " Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 044/104] mtd: fsl_elbc_nand: " Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 045/104] mtd: fsl_upm: " Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 046/104] mtd: mpc5121_nfc: " Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 047/104] mtd: ndfc: " Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 048/104] mtd: socrates_nand: " Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 049/104] mtd: drop of_mtd_parse_partitions() Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 050/104] physmap_of: separate parse_obsolete_partitions to separate parser Dmitry Eremin-Solenikov
2011-06-06 8:02 ` Artem Bityutskiy
2011-06-06 8:09 ` Dmitry Eremin-Solenikov
2011-06-06 8:11 ` Artem Bityutskiy
2011-06-06 8:13 ` Artem Bityutskiy
2011-06-06 8:24 ` Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 051/104] mtd: add a flags for partitions which should just leave smth. after them Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 052/104] ts72xx: use MTDPART_OFS_RETAIN for mtd partitioning Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 053/104] mtd: plat-nand: drop unused fields from platform_nand_data Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 054/104] mtd: add new API for handling MTD registration Dmitry Eremin-Solenikov
2011-06-02 14:51 ` [PATCH 055/104] mtd: lart.c: use mtd_device_parse_register Dmitry Eremin-Solenikov
2011-06-03 15:55 ` [RFC PATCH 000/104] mtd: cleanup partition parsing interface Artem Bityutskiy
2011-06-04 8:25 ` Dmitry Eremin-Solenikov
2011-06-06 7:04 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307026293-8535-7-git-send-email-dbaryshkov@gmail.com \
--to=dbaryshkov@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox