Re: [PATCHv2 1/6] nand/denali: convert to dev_() printk helpers

Artem Bityutskiy
2011-06-06T15:39:19Z

On Mon, 2011-06-06 at 14:51 +0100, Jamie Iles wrote:
> On Mon, Jun 06, 2011 at 04:11:55PM +0300, Artem Bityutskiy wrote:
> > On Fri, 2011-06-03 at 11:32 +0100, Jamie Iles wrote:
> > > if ((data_invalid - acc_clks * CLK_X) < 2)
> > > - dev_warn(denali->dev, "%s, Line %d: Warning!\n",
> > > - __FILE__, __LINE__);
> > > + dev_warn(denali->dev, "%s, Line %d: Warning!\n", __FILE__,
> > > + __LINE__);
> >
> > Do you really need __FILE__ and __LINE__ here? And may be you could also
> > change the warning message? Just printing "warning!" is a bit silly.
>
> I'm afraid I can't work out from the Denali documentation that we have
> what this is actually warning about. Chuanxiao, is there a better error
> message we can print here that can help users to debug it? Is this just
> an unsupported ONFI timing mode or something more sinister?

Well, we could kill it or change with "WARN_ON()" may be? Better to het
a comment from Chuanxiao of course ...

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)