Re: [PATCHv2 1/6] nand/denali: convert to dev_() printk helpers

Jamie Iles
2011-06-06T13:22:24Z

On Mon, Jun 06, 2011 at 04:11:55PM +0300, Artem Bityutskiy wrote:
> On Fri, 2011-06-03 at 11:32 +0100, Jamie Iles wrote:
> > if ((data_invalid - acc_clks * CLK_X) < 2)
> > - dev_warn(denali->dev, "%s, Line %d: Warning!\n",
> > - __FILE__, __LINE__);
> > + dev_warn(denali->dev, "%s, Line %d: Warning!\n", __FILE__,
> > + __LINE__);
>
> Do you really need __FILE__ and __LINE__ here? And may be you could also
> change the warning message? Just printing "warning!" is a bit silly.

OK, fair point (and the rest of your comments). I'll respin this and
try to rationalise the messages at the same time.

Jamie