Re: [PATCH 01/32] mtd: mtd_dataflash don't specify default parsing options

Artem Bityutskiy
2011-06-06T12:07:13Z

On Mon, 2011-06-06 at 15:19 +0400, Dmitry Eremin-Solenikov wrote:
> Hello,
>
> On Mon, Jun 6, 2011 at 3:04 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Mon, 2011-06-06 at 13:15 +0400, Dmitry Eremin-Solenikov wrote:
> >> Since 'cmdline, NULL' is now a default for parse_mtd_partitions, don't specify
> >> this in every driver, instead pass NULL to force parse_mtd_partitions
> >> to use default.
> >>
> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> >
> > Do you have a git URL with these patches?
>
> Yes. Unfortunately git.kernel.org syncs too slow now, so the kernel
> wasn't available
> at the time of sending an e-mail.
>
> Here it goes:
>
> The following changes since commit 099fbd4fd91fde9748d9ad927e59b6c36a2651cf:
>
> mtd: drop mtd_has_cmdlinepart() (2011-06-06 10:31:22 +0300)
>
> are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/lumag/mtd-cleanup.git
> mtd-cleanup-cmdline

OK, thanks, all the patches are in the l2 tree now. But one note:
please, after a mechanical change go through the patches and check that
them. E.g., in this case many patches could also merge the list of
parameters. I mean, if you are substituting something long by something
short, you check if you can merge lines. Otherwise, you check if some
lines became too long...

Thanks!

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)