From: Artem Bityutskiy <dedekind1@gmail.com>
To: roman.tereshonkov@nokia.com
Cc: linux-mtd@lists.infradead.org, kmpark@infradead.org,
dwmw2@infradead.org, m.szyprowski@samsung.com
Subject: RE: [PATCH] mtd: OneNAND: Fix wrong subpage_sft at 4KiB pagesize
Date: Mon, 06 Jun 2011 13:06:31 +0300 [thread overview]
Message-ID: <1307354791.3112.24.camel@localhost> (raw)
In-Reply-To: <1307354557.3112.21.camel@localhost>
On Mon, 2011-06-06 at 13:02 +0300, Artem Bityutskiy wrote:
> On Mon, 2011-06-06 at 09:42 +0000, roman.tereshonkov@nokia.com wrote:
> > What do mean by "no case to use the subpage"?
> >
> > According to the spec KFM4G16Q4M-xEBx the Number of Partial Program Cycles in the page (NOP)
> > is equal to 4 -> subpage_sft=2.
>
> I thought this means "not supported by HW". But if this is supported,
> then I'm very surprised why would we remove it. I'm dropping this patch
> from my tree.
OK, I actually did not put it to the l2 tree. And AFAICS this patch
basically reverts commit 99b17c08bca2810f5910b3027f1b9d82edf7a576, but
still leaves the data structures like onenand_oob_128.
So NACK for this patch - poor commit message, weird changes. I'm
surprised to see this from kmpark.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-06-06 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 6:48 [PATCH] mtd: OneNAND: Fix wrong subpage_sft at 4KiB pagesize Kyungmin Park
2011-06-03 15:41 ` Artem Bityutskiy
2011-06-06 9:42 ` roman.tereshonkov
2011-06-06 10:02 ` Artem Bityutskiy
2011-06-06 10:06 ` Artem Bityutskiy [this message]
2011-06-06 23:55 ` Kyungmin Park
2011-06-07 9:54 ` roman.tereshonkov
2011-06-07 10:10 ` Kyungmin Park
2011-06-08 0:59 ` Kyungmin Park
2011-06-08 10:53 ` Artem Bityutskiy
2011-06-08 13:26 ` Kyungmin Park
2011-06-08 9:56 ` roman.tereshonkov
2011-06-08 10:04 ` Kyungmin Park
2011-06-08 10:20 ` roman.tereshonkov
2011-06-08 10:27 ` Kyungmin Park
2011-06-08 10:37 ` roman.tereshonkov
2011-06-03 15:58 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307354791.3112.24.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kmpark@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox