From: Artem Bityutskiy <dedekind1@gmail.com>
To: Peter Wippich <pewi@gw-instruments.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: nandwrite with raw oob data
Date: Mon, 06 Jun 2011 15:10:46 +0300 [thread overview]
Message-ID: <1307362246.3112.45.camel@localhost> (raw)
In-Reply-To: <alpine.LSU.2.00.1106051821580.26001@redbean.intranet.gw-instruments.de>
On Sun, 2011-06-05 at 18:40 +0200, Peter Wippich wrote:
> Dear all,
>
> I run into the same problem as outlined here before:
> http://lists.infradead.org/pipermail/linux-mtd/2011-March/034516.html
>
> Going a little bit deeper it looks to me that writing any nand flash data
> with raw (precomputed ECC) OOB data is not possible at all with a recent
> Kernel and nandwrite version.
>
> What happens here is that nandwrite will set MTD_MODE_RAW when noecc is
> specified. Doing so will force the kernel driver to write OOB data only on
> a normal write. Obviously this will fail when someone is trying to write
> normal data to flash in MODE_RAW.
>
> Question: is this realy the intended behaviour ???
>
> It may be easy to fix this on kernel level, but may be there is some good
> reason I don't know to do it as it is. And I don't want to break things.
>
> Any comments welcome.
I think that is just broken stuff which is rarely used. Please, send a
set of fixes, but please, try to:
1. Fix both nandwrite and the kernel.
2. Test that non-raw functionality is not broken.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-06-06 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 16:40 nandwrite with raw oob data Peter Wippich
2011-06-06 12:10 ` Artem Bityutskiy [this message]
2011-06-06 13:11 ` Peter Wippich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307362246.3112.45.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pewi@gw-instruments.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox