From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bw0-f49.google.com ([209.85.214.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QTZjX-0004gq-1t for linux-mtd@lists.infradead.org; Mon, 06 Jun 2011 13:20:44 +0000 Received: by bwz1 with SMTP id 1so4682239bwz.36 for ; Mon, 06 Jun 2011 06:20:41 -0700 (PDT) Subject: Re: [PATCHv2 2/6] nand/denali: annotate pci init/exit functions with correct section From: Artem Bityutskiy To: Jamie Iles In-Reply-To: <1307097169-11744-3-git-send-email-jamie@jamieiles.com> References: <1307097169-11744-1-git-send-email-jamie@jamieiles.com> <1307097169-11744-3-git-send-email-jamie@jamieiles.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 06 Jun 2011 16:16:24 +0300 Message-ID: <1307366184.3112.70.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: David Woodhouse , linux-mtd@lists.infradead.org, Chuanxiao Dong Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2011-06-03 at 11:32 +0100, Jamie Iles wrote: > The module init exit functions should be annotated with __init and > __exit. > > Cc: David Woodhouse > Cc: Chuanxiao Dong > Cc: Artem Bityutskiy > Signed-off-by: Jamie Iles Would you please use "mtd: denali:" prefix? I cannot apply this patch because it depends on the previous patch. You could re-structure the code and make simpler patches like this go first, then they could be taken quicker. Thanks! -- Best Regards, Artem Bityutskiy (Артём Битюцкий)