From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/6] libmtd: add helper funcs for getting fds, regioninfo, and locked info
Date: Tue, 07 Jun 2011 09:50:36 +0300 [thread overview]
Message-ID: <1307429436.11104.43.camel@localhost> (raw)
In-Reply-To: <1307427548-29306-4-git-send-email-vapier@gentoo.org>
On Tue, 2011-06-07 at 02:19 -0400, Mike Frysinger wrote:
> +int mtd_open_dev1(int mtd_num)
> +{
> + char devpath[128];
> + int fd;
> +
> + sprintf(devpath, "/dev/mtd%i", mtd_num);
> + fd = open(devpath, O_RDONLY | O_CLOEXEC);
> + if (fd < 0)
> + return sys_errmsg("cannot open \"%s\"", devpath);
> +
Could we avoid hard-coding device node names?
We indeed have -m option in mtdutils which opens a device by its number.
But I think it was a mistake. Generally, MTD devices can have any name,
it is up to udev configuration. So I'd rather deprecate and would
require a list of device node names.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-06-07 6:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 6:19 [PATCH 1/6] jffs2: make lzo optional at build time Mike Frysinger
2011-06-07 6:19 ` [PATCH 2/6] mtdinfo: send help/version info to stdout Mike Frysinger
2011-06-07 6:36 ` Artem Bityutskiy
2011-06-07 15:00 ` Mike Frysinger
2011-06-08 11:10 ` Artem Bityutskiy
2011-06-07 8:40 ` Florian Fainelli
2011-06-07 15:02 ` [PATCH v2] ubi-utils: " Mike Frysinger
2011-06-08 11:13 ` Artem Bityutskiy
2011-06-07 6:19 ` [PATCH 3/6] libmtd: use O_CLOEXEC Mike Frysinger
2011-06-07 6:45 ` Artem Bityutskiy
2011-06-07 6:19 ` [PATCH 4/6] libmtd: add helper funcs for getting fds, regioninfo, and locked info Mike Frysinger
2011-06-07 6:50 ` Artem Bityutskiy [this message]
2011-06-07 6:56 ` Artem Bityutskiy
2011-06-07 7:04 ` Mike Frysinger
2011-06-07 7:30 ` Artem Bityutskiy
2011-06-07 15:28 ` [PATCH v2] libmtd: add helper funcs for getting regioninfo " Mike Frysinger
2011-06-07 15:52 ` [PATCH v3] " Mike Frysinger
2011-06-08 11:47 ` Artem Bityutskiy
2011-06-08 18:10 ` Mike Frysinger
2011-06-08 11:52 ` [PATCH v2] " Artem Bityutskiy
2011-06-08 12:27 ` Artem Bityutskiy
2011-06-08 18:12 ` Mike Frysinger
2011-06-07 6:19 ` [PATCH 5/6] mtdinfo: add regioninfo/sectormap display Mike Frysinger
2011-06-07 7:41 ` Artem Bityutskiy
2011-06-07 15:31 ` Mike Frysinger
2011-06-08 13:41 ` Artem Bityutskiy
2011-06-08 18:14 ` Mike Frysinger
2011-06-07 15:53 ` [PATCH v2] mtdinfo: add regioninfo/eraseblock map display Mike Frysinger
2011-06-08 13:35 ` Artem Bityutskiy
2011-06-08 18:26 ` Mike Frysinger
2011-06-08 19:02 ` [PATCH v3] " Mike Frysinger
2011-06-08 19:11 ` [PATCH v4] " Mike Frysinger
2011-06-09 6:25 ` Artem Bityutskiy
2011-06-07 6:19 ` [PATCH 6/6] flash_info: punt in favor of mtdinfo Mike Frysinger
2011-06-07 7:43 ` Artem Bityutskiy
2011-06-07 15:11 ` [PATCH v2] flash_info: deprecate Mike Frysinger
2011-06-08 11:15 ` Artem Bityutskiy
2011-06-07 6:34 ` [PATCH 1/6] jffs2: make lzo optional at build time Artem Bityutskiy
2011-06-07 6:59 ` Mike Frysinger
2011-06-07 7:20 ` Artem Bityutskiy
2011-06-07 7:16 ` Artem Bityutskiy
2011-06-07 15:16 ` Mike Frysinger
2011-06-08 11:28 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307429436.11104.43.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox