Re: [PATCH 01/44] mtd: add new API for handling MTD registration

Dmitry Eremin-Solenikov
2011-06-07T14:34:07Z

On 07.06.2011 17:44, Jamie Iles wrote:
> Hi Dmitry,
>
> This sounds like a good idea. Nitpick inline.
>
> Jamie
>
> On Tue, Jun 07, 2011 at 05:36:00PM +0400, Dmitry Eremin-Solenikov wrote:
>> Lots (nearly all) mtd drivers contain nearly the similar code that
>> calls parse_mtd_partitions, provides some platform-default values, if
>> parsing fails, and registers mtd device.
>>
>> This is an aim to provide single implementation of this scenario:
>> mtd_device_parse_register() which will handle all this parsing and
>> defaults.
>>
>> Signed-off-by: Dmitry Eremin-Solenikov<dbaryshkov@gmail.com>
>> ---
>> drivers/mtd/mtdcore.c | 30 ++++++++++++++++++++++++++++++
>> include/linux/mtd/mtd.h | 5 +++++
>> 2 files changed, 35 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
>> index c510aff..ac871ad 100644
>> --- a/drivers/mtd/mtdcore.c
>> +++ b/drivers/mtd/mtdcore.c
>> @@ -451,6 +451,36 @@ int mtd_device_register(struct mtd_info *master,
>> }
>> EXPORT_SYMBOL_GPL(mtd_device_register);
>>
>> +int mtd_device_parse_register(struct mtd_info *mtd,
>> + const char **part_probe_types,
>> + unsigned long origin,
>> + const struct mtd_partition *defparts,
>> + int defnr_parts)
>> +{
>> + int err;
>> + struct mtd_partition *parts;
>> +
>> + err = parse_mtd_partitions(mtd, part_probe_types,&parts, origin);
>> + if (err<= 0&& defnr_parts) {
>> + unsigned long size = sizeof(*parts) * defnr_parts;
>> + err = defnr_parts;
>> + parts = kzalloc(size, GFP_KERNEL);
>> + memcpy(parts, defparts, size);
>
> Shouldn't this check the return of kzalloc()? How about using kmemdup()
> instead of kzalloc() + memcpy()?

Good catch! Thank you.

> Also some kernel-doc to describe the search order would be nice.

Search order is mainly detailed either by defaults specified in
mtdpart.c or by probe types which user specifies.

--
With best wishes
Dmitry