From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QUhlz-0001nf-8j for linux-mtd@lists.infradead.org; Thu, 09 Jun 2011 16:07:55 +0000 Received: by fxm14 with SMTP id 14so1537287fxm.36 for ; Thu, 09 Jun 2011 09:07:51 -0700 (PDT) Subject: Re: [PATCH v2 2/4] mtd: nand: convert printk() to pr_*() From: Artem Bityutskiy To: Brian Norris In-Reply-To: References: <1307544227.31223.115.camel@localhost> <1307557519-31269-1-git-send-email-computersforpeace@gmail.com> <1307605456.7374.35.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Thu, 09 Jun 2011 19:03:32 +0300 Message-ID: <1307635412.7374.128.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, David Woodhouse , Igor Grinberg Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2011-06-09 at 09:00 -0700, Brian Norris wrote: > On Thu, Jun 9, 2011 at 12:44 AM, Artem Bityutskiy wrote: > > Wait, and why are we using pr_* while it is better to use dbg_* ? :-) > > Just so we're on the same page...did you say "dbg_*" when you really > meant "dev_*"? Yes, I meant dev_* > Anyway, the answer is: I'm mostly trying to do as little shakeup as > possible, so "printk" could translate pretty directly to the "pr_*" > with shorter code, etc. If it makes as much (or more) sense to have > the device name on all the prints, then I can just as well do it that > way. Yes, I think it makes much more sense to specify for which device (out of possibly many!) this message belongs. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)