From: "Brian Norris" <computersforpeace@gmail.com>
To: "Artem Bityutskiy" <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Mike Frysinger <vapier.adi@gmail.com>
Subject: [PATCH v2 6/7] nanddump: add --oob option
Date: Tue, 21 Jun 2011 08:46:40 -0700 [thread overview]
Message-ID: <1308671201-18197-7-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1308671201-18197-1-git-send-email-computersforpeace@gmail.com>
Adds an explicit option for including OOB data in our data dump.
Currently, this is the default behavior, but in the next release, the
default will be to exclude OOB data. This is done to mirror the '-o'
option in nandwrite.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
nanddump.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/nanddump.c b/nanddump.c
index 81ada28..7941aa2 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -59,6 +59,7 @@ static void display_help(void)
"-l length --length=length Length\n"
"-n --noecc Read without error correction\n"
"-o --omitoob Omit oob data\n"
+" --oob Dump OOB data\n"
"-p --prettyprint Print nice (hexdump)\n"
"-q --quiet Don't display progress and status messages\n"
"-s addr --startaddress=addr Start address\n"
@@ -127,6 +128,7 @@ static void process_options(int argc, char * const argv[])
{"help", no_argument, 0, 0},
{"version", no_argument, 0, 0},
{"bb", required_argument, 0, 0},
+ {"oob", no_argument, 0, 0},
{"forcebinary", no_argument, 0, 'a'},
{"canonicalprint", no_argument, 0, 'c'},
{"file", required_argument, 0, 'f'},
@@ -170,6 +172,9 @@ static void process_options(int argc, char * const argv[])
error++;
bb_default = false;
break;
+ case 3: /* --oob */
+ omitoob = false;
+ break;
}
break;
case 'b':
--
1.7.0.4
next prev parent reply other threads:[~2011-06-21 15:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 15:46 [PATCH v2 0/7] new nanddump defaults Brian Norris
2011-06-21 15:46 ` [PATCH v2 1/7] nanddump: add --bb=METHOD option Brian Norris
2011-06-21 15:46 ` [PATCH v2 2/7] nanddump: remove --skipbad, leaving --bb=skipbad Brian Norris
2011-06-21 15:46 ` [PATCH v2 3/7] nanddump: deprecation messages for old BB options Brian Norris
2011-06-21 19:38 ` Mike Frysinger
2011-06-21 15:46 ` [PATCH v2 4/7] nanddump: warn about new default BB handling Brian Norris
2011-06-21 19:37 ` Mike Frysinger
2011-06-21 15:46 ` [PATCH v2 5/7] feature-removal-schedule: describe nanddump changes Brian Norris
2011-06-21 15:46 ` Brian Norris [this message]
2011-06-21 15:46 ` [PATCH v2 7/7] nanddump: document, warn about future default --omitoob Brian Norris
2011-06-21 19:39 ` Mike Frysinger
2011-06-21 19:40 ` [PATCH v2 0/7] new nanddump defaults Mike Frysinger
2011-06-21 22:36 ` Brian Norris
2011-06-22 16:49 ` [PATCH v3 0/7] prepare new nanddump options, defaults Brian Norris
2011-06-23 15:02 ` Artem Bityutskiy
2011-06-23 15:04 ` Artem Bityutskiy
2011-06-23 15:52 ` Mike Frysinger
2011-06-23 23:00 ` Brian Norris
2011-06-23 23:14 ` Mike Frysinger
2011-06-23 23:27 ` Brian Norris
2011-06-23 23:36 ` Mike Frysinger
2011-06-23 23:40 ` Brian Norris
2011-06-23 23:45 ` Mike Frysinger
2011-06-23 23:48 ` Brian Norris
2011-06-24 20:20 ` Artem Bityutskiy
2011-06-26 7:15 ` Peter Korsgaard
2011-06-24 17:37 ` Brian Norris
2011-06-24 18:28 ` Mike Frysinger
2011-06-24 19:21 ` Artem Bityutskiy
2011-06-24 20:11 ` Artem Bityutskiy
2011-06-24 20:15 ` Artem Bityutskiy
2011-06-24 19:38 ` Artem Bityutskiy
2011-06-22 16:49 ` [PATCH v3 1/7] nanddump: add --bb=METHOD option Brian Norris
2011-06-22 16:49 ` [PATCH v3 2/7] nanddump: remove --skipbad, leaving --bb=skipbad Brian Norris
2011-06-22 16:49 ` [PATCH v3 3/7] nanddump: update help message for BB method changes Brian Norris
2011-06-22 16:49 ` [PATCH v3 4/7] nanddump: warn about new default BB handling Brian Norris
2011-06-22 16:49 ` [PATCH v3 5/7] feature-removal-schedule: describe nanddump changes Brian Norris
2011-06-22 16:49 ` [PATCH v3 6/7] nanddump: add --oob option Brian Norris
2011-06-22 16:49 ` [PATCH v3 7/7] nanddump: document, warn about future default --omitoob Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308671201-18197-7-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).