From: Mike Frysinger <vapier@gentoo.org>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] punt redundant libcrc32
Date: Sat, 25 Jun 2011 00:57:37 -0400 [thread overview]
Message-ID: <1308977857-3220-1-git-send-email-vapier@gentoo.org> (raw)
The libcrc32.a is only used in one place: mkfs.ubifs. But this also
uses libmtd.a, and the only file in libcrc32.a is also in libmtd.a.
So libcrc32.a itself is completely redundant. Punt!
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
lib/Makefile | 5 ++---
mkfs.ubifs/Makefile | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/Makefile b/lib/Makefile
index 9de6a7d..9b01d32 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -6,12 +6,11 @@ SUBDIRS =
# CFLAGS += -Werror
CPPFLAGS += -I../include
-LIBS = libmtd libcrc32
-TARGETS = libmtd.a libcrc32.a
+LIBS = libmtd
+TARGETS = libmtd.a
include ../common.mk
-$(BUILDDIR)/libcrc32.a: $(addprefix $(BUILDDIR)/, libcrc32.o)
$(BUILDDIR)/libmtd.a: $(addprefix $(BUILDDIR)/,\
libmtd.o libmtd_legacy.o libcrc32.o libfec.o)
diff --git a/mkfs.ubifs/Makefile b/mkfs.ubifs/Makefile
index 499f9e5..ba21a8c 100644
--- a/mkfs.ubifs/Makefile
+++ b/mkfs.ubifs/Makefile
@@ -7,7 +7,7 @@ ALL_SOURCES=*.[ch] hashtable/*.[ch]
TARGETS = mkfs.ubifs
LDLIBS_mkfs.ubifs = -lz -llzo2 -lm -luuid -L$(BUILDDIR)/../ubi-utils/ -lubi
-LDLIBS_mkfs.ubifs += -L$(BUILDDIR)/../lib -lmtd -lcrc32
+LDLIBS_mkfs.ubifs += -L$(BUILDDIR)/../lib -lmtd
LDLIBS_mkfs.ubifs += $(ZLIBLDFLAGS) $(LZOLDFLAGS)
include ../common.mk
--
1.7.5.3
next reply other threads:[~2011-06-25 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 4:57 Mike Frysinger [this message]
2011-06-25 6:12 ` [PATCH] punt redundant libcrc32 Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308977857-3220-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox