From: Artem Bityutskiy <dedekind1@gmail.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
linux-next@vger.kernel.org, linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2/2] mtd/ofpart: add ofoldpart alias
Date: Mon, 27 Jun 2011 09:03:26 +0300 [thread overview]
Message-ID: <1309154611.23597.18.camel@sauron> (raw)
In-Reply-To: <BANLkTikmCY8UjJWRKTkM_QW2_Bxw4yqPfQ@mail.gmail.com>
On Mon, 2011-06-27 at 09:51 +0400, Dmitry Eremin-Solenikov wrote:
> On 6/27/11, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Mon, 2011-06-27 at 01:03 +0400, Dmitry Eremin-Solenikov wrote:
> >> ofpart.ko also provides ofoldpart MTD parser. Add respective
> >> MODULE_ALIAS("ofoldpart"); declaration.
> >>
> >
> > Why we need the alias?
>
> Please check the parse_mtd_partitions code. If requested parser
> isn't registered, it tries to load corresponding module. So, this alias
> is necessary in the semi-bogus case when one will have the list
> of parsers containing ofoldpart, but not ofpart partition parser.
Fair enough, but would you please prepend MODULE_ALIAS with a comment
like this which explains why we need the alias?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-06-27 6:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 21:02 [PATCH 0/2] finish modularization of ofpart parser Dmitry Eremin-Solenikov
2011-06-26 21:02 ` [PATCH 1/2] mtd: make ofpart buildable as a separate module Dmitry Eremin-Solenikov
2011-06-26 23:29 ` Randy Dunlap
2011-06-27 5:49 ` Artem Bityutskiy
2011-06-26 21:03 ` [PATCH 2/2] mtd/ofpart: add ofoldpart alias Dmitry Eremin-Solenikov
2011-06-26 23:35 ` Grant Likely
2011-06-27 5:45 ` Artem Bityutskiy
2011-06-27 5:51 ` Dmitry Eremin-Solenikov
2011-06-27 6:03 ` Artem Bityutskiy [this message]
2011-06-27 12:34 ` Dmitry Eremin-Solenikov
2011-06-28 7:41 ` Artem Bityutskiy
2011-06-28 8:09 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309154611.23597.18.camel@sauron \
--to=dedekind1@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox