Re: [PATCH 0/3] fixups for OOB ECC problems

Artem Bityutskiy
2011-06-29T06:58:16Z

On Tue, 2011-06-28 at 16:28 -0700, Brian Norris wrote:
> Hello,
>
> Now that we have added the possibility that mtd->read_oob returns
> -EUCLEAN or -EBADMSG for corrected bitflips and for uncorrectable errors,
> respectively, there are more pieces of code that need to take this into
> account. These patches should address some of these by ignoring bitflips
> when bit accuracy is not needed or by ignoring corrected errors when
> scrubbing would be unnecessary.
>
> There are still other cases to address, for example, some flash-based BBT
> code.
>
> This applies on top of l2-mtd-2.6.git. Patch 3 is an amendment to commit
> abf386c475beab813dc9b3366e592e00255e987a, ("mtd: nand: handle ECC errors
> in OOB"), so it can be squashed in if you want. Let me know if you want
> me to do this and do a resend.

Do you test these things somehow? I'd just injected some code to a
driver or nandsim which returns -EUCLEAN for OOB and check what fails.

--
Best Regards,
Artem Bityutskiy