[PATCH v2 2/5] mtdinfo: refactor code to remove "args.all" dependency

Brian Norris
2011-08-09T21:37:22Z

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
ubi-utils/mtdinfo.c | 13 +++----------
1 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/ubi-utils/mtdinfo.c b/ubi-utils/mtdinfo.c
index b4a2f4c..0a20c76 100644
--- a/ubi-utils/mtdinfo.c
+++ b/ubi-utils/mtdinfo.c
@@ -338,8 +338,7 @@ static int print_dev_info(libmtd_t libmtd, const struct mtd_info *mtd_info, int
return 0;
}

-static int print_general_info(libmtd_t libmtd, const struct mtd_info *mtd_info,
- int all)
+static int print_general_info(libmtd_t libmtd, const struct mtd_info *mtd_info)
{
int i, err, first = 1;
struct mtd_dev_info mtd;
@@ -366,15 +365,9 @@ static int print_general_info(libmtd_t libmtd, const struct mtd_info *mtd_info,
}
}
printf("\n");
- printf("Sysfs interface supported: %s\n",
+ printf("Sysfs interface supported: %s\n\n",
mtd_info->sysfs_supported ? "yes" : "no");

- if (!all)
- return 0;
-
- first = 1;
- printf("\n");
-
for (i = mtd_info->lowest_mtd_num;
i <= mtd_info->highest_mtd_num; i++) {
err = print_dev_info(libmtd, mtd_info, i);
@@ -421,7 +414,7 @@ int main(int argc, char * const argv[])
goto out_libmtd;
err = print_dev_info(libmtd, &mtd_info, mtdn);
} else
- err = print_general_info(libmtd, &mtd_info, args.all);
+ err = print_general_info(libmtd, &mtd_info);
if (err)
goto out_libmtd;

--
1.7.0.4