From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Brian Foster <brian.foster@maxim-ic.com>,
Brian Norris <computersforpeace@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [BUG] mtdinfo -a: Tries to open NULL pointer for NOR with Eraseblock Regions
Date: Mon, 15 Aug 2011 07:11:27 +0300 [thread overview]
Message-ID: <1313381489.2200.19.camel@koala> (raw)
In-Reply-To: <CAMjpGUcjhuc6MaH0y2vGdM5ru00BJEmVeBwMUebkbfoxDNY28g@mail.gmail.com>
On Tue, 2011-08-09 at 13:34 -0400, Mike Frysinger wrote:
> On Mon, Aug 8, 2011 at 19:19, Brian Norris wrote:
> > "Alternatively, --all only prints what it can get,
> > and --help warns there _may_ be additional data not
> > printed by --all (and to use ‘mtdinfo /dev/mtd<N>’)."
>
> that's really the only other option of the three.
> 1: add region_info to sysfs
> 2: add a warning --all that it could be incomplete
> 3: have --all use the legacy lookup func to get /dev/mtd#
How about: make a quick fix and release mtd-utils-1.4.6, then just kill
the -a option. I'd vote for eliminating all the code which has to
guess/assume/find the device node names - I think they always have to be
passed by the user instead. We can do the elimination the usual way -
first add the warning, then kill.
This is also a good way to go because mtd stuff does not have enough
people for excellent maintenance, and keeping it simpler should be
helpful.
Thoughts?
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2011-08-15 4:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 9:48 [BUG] mtdinfo -a: Tries to open NULL pointer for NOR with Eraseblock Regions Brian Foster
2011-07-25 17:10 ` Brian Norris
2011-07-26 7:21 ` Brian Foster
2011-08-04 17:46 ` Brian Norris
2011-08-04 22:41 ` Mike Frysinger
2011-08-06 0:09 ` Brian Norris
2011-08-06 1:18 ` Mike Frysinger
2011-08-08 8:16 ` Brian Foster
2011-08-08 23:19 ` Brian Norris
2011-08-09 7:27 ` Brian Foster
2011-08-09 17:34 ` Mike Frysinger
2011-08-09 19:59 ` Brian Norris
2011-08-15 4:11 ` Artem Bityutskiy [this message]
2011-08-15 23:13 ` Brian Norris
2011-08-16 14:17 ` Artem Bityutskiy
2011-08-16 7:31 ` Brian Foster
2011-08-16 17:47 ` Brian Norris
2011-08-08 8:10 ` Brian Foster
2011-08-08 8:40 ` Brian Foster
2011-08-05 7:24 ` Brian Foster
2011-08-06 0:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313381489.2200.19.camel@koala \
--to=dedekind1@gmail.com \
--cc=brian.foster@maxim-ic.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox