From: Artem Bityutskiy <dedekind1@gmail.com>
To: srimugunthan dhandapani <srimugunthan.dhandapani@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: mtdchar, parallel erase with ioctl
Date: Mon, 15 Aug 2011 18:24:52 +0300 [thread overview]
Message-ID: <1313421896.8691.7.camel@sauron> (raw)
In-Reply-To: <CAMjNe_fD8R39w8FScVHLK2q26uuEgd9vuG0e+aLKF7cea-fkeA@mail.gmail.com>
On Tue, 2011-08-02 at 15:00 +0530, srimugunthan dhandapani wrote:
> Hi all,
> The mtdchar layer when it does erase using ioctl, it takes a lock
> mtd_mutex.So the erases can only be done sequentially one after
> another. The hardware that i am working on has multiple banks and
> supports parallel erase operations. I have modified mtd_unlocked_ioctl
> function in mtdchar.c, to not take lock for erase commands(as shown
> below). With that i am able to do parallel erases. Is this patch an
> acceptable solution or what is the correct way to do this?
No, mtd_mutex is needed e.g., because it makes sure that no-one removes
the MTD device meanwhile. I do not see why exactly mtd_mutex prevents
parallel erase.
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2011-08-15 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 9:30 mtdchar, parallel erase with ioctl srimugunthan dhandapani
2011-08-15 15:24 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313421896.8691.7.camel@sauron \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=srimugunthan.dhandapani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox