From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw0-f49.google.com ([209.85.213.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QtKQO-00055M-A9 for linux-mtd@lists.infradead.org; Tue, 16 Aug 2011 14:15:25 +0000 Received: by ywp17 with SMTP id 17so4021529ywp.36 for ; Tue, 16 Aug 2011 07:15:21 -0700 (PDT) Subject: Re: [BUG] mtdinfo -a: Tries to open NULL pointer for NOR with Eraseblock Regions From: Artem Bityutskiy To: Brian Norris Date: Tue, 16 Aug 2011 17:17:00 +0300 In-Reply-To: References: <201107251148.51262.brian.foster@maxim-ic.com> <201107260921.44512.brian.foster@maxim-ic.com> <1313381489.2200.19.camel@koala> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1313504225.21711.3.camel@sauron> Mime-Version: 1.0 Cc: Brian Foster , "linux-mtd@lists.infradead.org" , Mike Frysinger Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2011-08-15 at 16:13 -0700, Brian Norris wrote: > This way, we do not rely on guessing any paths; we simply use the > sysfs information that is exposed, among other purposes, for cases > cases like this, right? And then (as I stated on another message in > this thread) we could even support the "region info" on newer kernels, > if somebody ever does the work to export them. I think this solution > involves no extra work right now, does not remove valuable features, > does not make dirty assumptions about node names, and can take > advantage of new sysfs features in the future. The main downside I see > is the potential (documented) difference in information printed by > `mtdinfo --all' vs. `mtdinfo /dev/mtdX'. Yes, fair enough, just pushed your fix and cleanups, thanks! -- Best Regards, Artem Bityutskiy