From: "Brian Norris" <computersforpeace@gmail.com>
To: "Artem Bityutskiy" <dedekind1@gmail.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
Kevin Cernekee <cernekee@gmail.com>,
b35362@freescale.com, linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Matthew Creech <mlcreech@gmail.com>
Subject: [RFC 1/5] mtd: support MTD_MODE_RAW for writing OOB
Date: Wed, 17 Aug 2011 16:50:25 -0700 [thread overview]
Message-ID: <1313625029-19546-2-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1313625029-19546-1-git-send-email-computersforpeace@gmail.com>
mtd_do_write_oob does not pass information about whether to write in RAW
mode to the lower layers (e.g., NAND). We should pass MTD_OOB_RAW or
MTD_OOB_PLACE based on the MTD file mode.
This fixes issues with `nandwrite -n' and the MEMWRITEOOB[64] ioctls.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/mtd/mtdchar.c | 3 ++-
drivers/mtd/nand/nand_base.c | 9 ++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index a75d555..7ca4361 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -391,6 +391,7 @@ static int mtd_do_writeoob(struct file *file, struct mtd_info *mtd,
uint64_t start, uint32_t length, void __user *ptr,
uint32_t __user *retp)
{
+ struct mtd_file_info *mfi = file->private_data;
struct mtd_oob_ops ops;
uint32_t retlen;
int ret = 0;
@@ -412,7 +413,7 @@ static int mtd_do_writeoob(struct file *file, struct mtd_info *mtd,
ops.ooblen = length;
ops.ooboffs = start & (mtd->oobsize - 1);
ops.datbuf = NULL;
- ops.mode = MTD_OOB_PLACE;
+ ops.mode = (mfi->mode == MTD_MODE_RAW) ? MTD_OOB_RAW : MTD_OOB_PLACE;
if (ops.ooboffs && ops.ooblen > (mtd->oobsize - ops.ooboffs))
return -EINVAL;
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index d2ee68a..e2b1c90 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2401,7 +2401,14 @@ static int nand_do_write_oob(struct mtd_info *mtd, loff_t to,
chip->pagebuf = -1;
nand_fill_oob(mtd, ops->oobbuf, ops->ooblen, ops);
- status = chip->ecc.write_oob(mtd, chip, page & chip->pagemask);
+
+ if (ops->mode == MTD_OOB_RAW) {
+ status = 0;
+ chip->cmdfunc(mtd, NAND_CMD_SEQIN, 0x00, page);
+ chip->ecc.write_page_raw(mtd, chip, NULL);
+ } else {
+ status = chip->ecc.write_oob(mtd, chip, page & chip->pagemask);
+ }
if (status)
return status;
--
1.7.0.4
next prev parent reply other threads:[~2011-08-17 23:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 23:50 [RFC 0/5] fix data+OOB writes, add ioctl Brian Norris
2011-08-17 23:50 ` Brian Norris [this message]
2011-08-22 8:35 ` [RFC 1/5] mtd: support MTD_MODE_RAW for writing OOB Artem Bityutskiy
2011-08-22 20:08 ` Brian Norris
2011-08-23 4:47 ` Artem Bityutskiy
2011-08-23 5:25 ` Jason Liu
2011-08-23 19:57 ` Brian Norris
2011-08-17 23:50 ` [RFC 2/5] mtd: support MTD_MODE_RAW for reading OOB Brian Norris
2011-08-22 8:38 ` Artem Bityutskiy
2011-08-17 23:50 ` [RFC 3/5] mtd: do not assume oobsize is power of 2 Brian Norris
2011-08-22 8:46 ` Artem Bityutskiy
2011-08-22 20:21 ` Brian Norris
2011-08-17 23:50 ` [RFC 4/5] mtd: move mtd_oob_mode_t to shared kernel/user space Brian Norris
2011-08-22 8:50 ` Artem Bityutskiy
2011-08-22 21:43 ` Brian Norris
2011-08-23 5:30 ` Artem Bityutskiy
2011-08-23 17:24 ` Brian Norris
2011-08-17 23:50 ` [RFC 5/5] mtd: add MEMWRITEDATAOOB ioctl Brian Norris
2011-08-22 8:56 ` Artem Bityutskiy
2011-08-23 0:04 ` Brian Norris
2011-08-23 6:05 ` Artem Bityutskiy
2011-08-23 6:06 ` Artem Bityutskiy
2011-08-23 6:11 ` Artem Bityutskiy
2011-08-22 10:02 ` [RFC 0/5] fix data+OOB writes, add ioctl Artem Bityutskiy
2011-08-22 12:04 ` Ivan Djelic
2011-08-22 12:16 ` Artem Bityutskiy
2011-08-23 6:48 ` Ricard Wanderlof
2011-08-23 16:47 ` Brian Norris
2011-08-24 15:36 ` Ricard Wanderlof
2011-08-24 18:01 ` Brian Norris
2011-08-25 7:21 ` Artem Bityutskiy
2011-08-25 9:33 ` Ricard Wanderlof
2011-08-25 17:54 ` Brian Norris
2011-08-26 12:41 ` Ricard Wanderlof
2011-08-22 23:42 ` Brian Norris
2011-08-23 6:01 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313625029-19546-2-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=b35362@freescale.com \
--cc=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mlcreech@gmail.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox