From: Brian Norris <computersforpeace@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Kevin Cernekee <cernekee@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: [PATCH 00/10] nandwrite: clean out old ioctls
Date: Fri, 19 Aug 2011 10:07:46 -0700 [thread overview]
Message-ID: <1313773676-12879-1-git-send-email-computersforpeace@gmail.com> (raw)
Hello,
This series cleans up some coding style, but it primarily deals with
several options to nandwrite that have rotted. Mostly, this deals with
MEMSETOOBSEL, which hasn't existed since kernel 2.6.17 - see commit:
[MTD] NAND Consolidate oobinfo handling
Sat May 27 20:36:12 2006 +0200
commit ff268fb8791cf18df536113355d7184007c269d9
For reference, MEMSETOOBSEL was "replaced" with MTDFILEMODE in the same
kernel release:
[MTD] NAND Expose the new raw mode function and status info to userspace
Tue May 30 00:37:34 2006 +0200
commit f1a28c02843efcfcc41982149880bac3ac180234
Several features depended (in part or entirely) on the MEMSETOOBSEL
ioctl: the -j, -y, and -a options to nandwrite and by extension the -f
(--forcelegacy) option which handled special cases for -j and -y. There
are also pieces of nanddump that relied on this behavior as a backup. We
just remove them, since they have been useless for over 5 years.
There shouldn't be any actual loss of functionality in these patches so
far (at least, not very much); let me know if there's something critical
I'm missing.
On the other hand, there is plenty of value in these edits, since it
leaves room for more rennovation and addition of newer, better kernel
interfaces for writing data and changing OOB modes.
Brian
Brian Norris (10):
mtd_debug: fixup style
mtd_debug: replace #defines with enum
mtd-utils: use __func__ instead of __FUNCTION__
nandwrite: remove C99 comment style
nandwrite: remove `autoplace' features
nandwrite: kill more MEMSETOOBSEL
nandwrite: kill -j, -y, and -f options
nandwrite: cleanup "oobinfochanged" leftovers
nandwrite: refactor "old_oobinfo" code
nanddump: kill usages of MEMSETOOBSEL ioctl
mtd_debug.c | 355 ++++++++++++++++++++++------------------------
nanddump.c | 43 +-----
nandwrite.c | 174 ++++-------------------
tests/ubi-tests/common.c | 10 +-
4 files changed, 205 insertions(+), 377 deletions(-)
--
1.7.6
next reply other threads:[~2011-08-19 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 17:07 Brian Norris [this message]
2011-08-19 17:07 ` [PATCH 01/10] mtd_debug: fixup style Brian Norris
2011-08-19 17:07 ` [PATCH 02/10] mtd_debug: replace #defines with enum Brian Norris
2011-08-19 17:07 ` [PATCH 03/10] mtd-utils: use __func__ instead of __FUNCTION__ Brian Norris
2011-08-19 17:07 ` [PATCH 04/10] nandwrite: remove C99 comment style Brian Norris
2011-08-19 17:07 ` [PATCH 05/10] nandwrite: remove `autoplace' features Brian Norris
2011-08-19 17:07 ` [PATCH 06/10] nandwrite: kill more MEMSETOOBSEL Brian Norris
2011-08-19 17:07 ` [PATCH 07/10] nandwrite: kill -j, -y, and -f options Brian Norris
2011-08-19 17:07 ` [PATCH 08/10] nandwrite: cleanup "oobinfochanged" leftovers Brian Norris
2011-08-19 17:07 ` [PATCH 09/10] nandwrite: refactor "old_oobinfo" code Brian Norris
2011-08-19 17:07 ` [PATCH 10/10] nanddump: kill usages of MEMSETOOBSEL ioctl Brian Norris
2011-08-23 6:31 ` Artem Bityutskiy
2011-08-23 16:19 ` Brian Norris
2011-08-23 6:29 ` [PATCH 00/10] nandwrite: clean out old ioctls Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313773676-12879-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox